Bug 339098

Summary:	JJ: Overhaul KNotify notification events to use more descriptive event titles
Product:	[Applications] konversation	Reporter:	Eike Hein <hein>
Component:	notifications	Assignee:	Konversation Bugs <konversation-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bshah, hein
Priority:	NOR
Version First Reported In:	frameworks
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/konversation/900baea903d839e6f007293c07eef51856b6c78f	Version Fixed/Implemented In:
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	337512

Description Eike Hein 2014-09-15 15:35:02 UTC

Konversation's KNotify notification events currently use the event name from the config as notification title. It would be nicer to explicitly pass a more useful, dynamic title, e.g. "<name> mentioned you in <channel>" instead of the generic "Someone mentioned your nick".

This would improve the user experience when running under Plasma Desktop 5, where consecutive notification events with identical titles are merged into a single notification, making it impossible to e.g. tell apart two pings from different channels in the notifications.

Comment 1 Eike Hein 2014-11-30 14:58:43 UTC

Git commit 900baea903d839e6f007293c07eef51856b6c78f by Eike Hein, on behalf of eli mackenzie.
Committed on 30/11/2014 at 14:57.
Pushed by hein into branch '1.6'.

Override event description with non-generic notification titles.

This prevents Plasma Desktop 5 from merging notification events
from different sources (channel/nick).

M  +22   -10   src/notificationhandler.cpp

http://commits.kde.org/konversation/900baea903d839e6f007293c07eef51856b6c78f