Bug 338869

Summary:	BQM Watermark tool : add new option to rotate text
Product:	[Applications] digikam	Reporter:	Pento <administrator>
Component:	Plugin-Bqm-WaterMark	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	ahmed.fathi.abdelmageed, caulier.gilles, oxdef+kde
Priority:	NOR
Version:	4.2.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/digikam/d54da04770450fa56a712d05485b73f023b008c2	Version Fixed In:	5.5.0
Attachments:	patch for watermark orientation feature. also handles exif data correctly photos for the feature provided by the previous patch

Description Pento 2014-09-07 07:43:50 UTC

Often it is need to not only position of watermark but also rotation of the text

Reproducible: Always

Steps to Reproduce:
1. Open digiKam and navigate to some album
2. Select images and add them to new batch queue
3. Enable Watermark tool

Actual Results:  
There is no option for rotation of the text. Only position and margins.

Expected Results:  
Option for rotation: 90, -90, 180

Same functionality you can see in main editor tool "Add Text"

Comment 1 Ahmed Fathi 2017-02-08 21:56:02 UTC

Created attachment 103909 [details]
patch for watermark orientation feature. also handles exif data correctly

This patch provides this feature. It also handles the exif data correctly. if the exif data specifies , for example , that the image is rotated 90 degrees clockwise, and the user chooses to place a water mark at the bottom right of the photo, It will be placed on the bottom right of the photo as expected. This was the problem proposed by the following two entries : 

https://bugs.kde.org/show_bug.cgi?id=250642
https://bugs.kde.org/show_bug.cgi?id=290944

In the next comment I provide some screen shots of the watermark orientation feature, in addition to some screenshots for the watermark orientation + exif data orientation side by side

Comment 2 Ahmed Fathi 2017-02-08 21:57:42 UTC

Created attachment 103910 [details]
photos for the feature provided by the previous patch

Comment 3 caulier.gilles 2017-02-09 21:32:26 UTC

Git commit d54da04770450fa56a712d05485b73f023b008c2 by Gilles Caulier.
Committed on 09/02/2017 at 21:24.
Pushed by cgilles into branch 'master'.

apply patch #103909 to add rotation feature in BQM watermark tool with exif orientation support.
Related: bug 250642, bug 290944
FIXED-IN: 5.5.0

M  +6    -1    NEWS
M  +50   -0    libs/dimg/dimg.cpp
M  +6    -1    libs/dimg/dimg.h
M  +6    -0    libs/threadimageio/loadsavethread.cpp
M  +5    -0    libs/threadimageio/loadsavethread.h
M  +83   -12   utilities/queuemanager/tools/decorate/watermark.cpp
M  +1    -1    utilities/queuemanager/tools/decorate/watermark.h

https://commits.kde.org/digikam/d54da04770450fa56a712d05485b73f023b008c2