Bug 338729

Summary: Ask for confirmation before deleting wallpapers
Product: [Plasma] plasmashell Reporter: Elias Probst <mail>
Component: Image & Slideshow wallpaper pluginsAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: major CC: aleixpol, antonis.tsiapaliokas, kde, kde, lukas
Priority: NOR    
Version: master   
Target Milestone: 1.0   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: http://commits.kde.org/plasma-workspace/50942e2618f3ed26f8eac8f264656617bb113ec6 Version Fixed In:
Sentry Crash Report:

Description Elias Probst 2014-09-01 12:46:10 UTC 
Currently, the wallpaper config dialog doesn't ask for confirmation before deleting wallpapers dropped into ~/.local/share/wallpapers or downloaded via GHNS.

This could result in loosing files or putting the user in a situation where a wallpaper is accidentally deleted whose name the user can't remember anymore to re-download it via GHNS.

As this can happen easily as one just needs to accidentally click the overlay icon of a wallpaper in the configuration dialog, a confirmation dialog should be shown first before deleting a wallpaper!
Comment 1 David Edmundson 2014-10-01 13:32:21 UTC 
Removing an image from the wallpaper selection doesn't remove it.
Comment 2 Lukáš Tinkl 2014-10-01 14:29:01 UTC 
Here it deletes the file hard from the disk...
Comment 3 David Edmundson 2014-10-01 14:30:09 UTC 
How are you adding the file?
Comment 4 Lukáš Tinkl 2014-10-01 14:39:15 UTC 
Using the Open... button
Comment 5 Aleix Pol 2014-11-24 16:36:32 UTC 
bump? seems like an important one...
Comment 6 Kai Uwe Broulik 2014-12-27 13:47:42 UTC 
When the image is in QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/wallpapers/" it gets deleted when removed from the list, if it's a Plasma package it is uninstalled. Otherwise the config is just updated. Perhaps there's a glitch in Image::removeWallpaper(), like doing QUrl nameUrl(name); and stuff.
Comment 7 Antonis Tsiapaliokas 2015-04-01 15:29:47 UTC 
I have upload a patch in the rb which is adding a dialog for confirmation before the delete of the wallpaper.

https://git.reviewboard.kde.org/r/123211/
Comment 8 Antonis Tsiapaliokas 2015-04-03 16:05:48 UTC 
Git commit 50942e2618f3ed26f8eac8f264656617bb113ec6 by Antonis Tsiapaliokas.
Committed on 03/04/2015 at 16:05.
Pushed by tsiapaliokas into branch 'master'.

Ask for confirmation before deleting a wallpaper.

REVIEW: 123211

M  +47   -0    wallpapers/image/backgroundlistmodel.cpp
M  +9    -3    wallpapers/image/backgroundlistmodel.h
M  +7    -0    wallpapers/image/image.cpp
M  +1    -0    wallpapers/image/image.h
M  +24   -3    wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
M  +5    -1    wallpapers/image/imagepackage/contents/ui/config.qml

http://commits.kde.org/plasma-workspace/50942e2618f3ed26f8eac8f264656617bb113ec6