Bug 338222

Summary:	False positive critical warnings for KStandardActions
Product:	[Frameworks and Libraries] frameworks-kxmlgui	Reporter:	Cristian Oneț <onet.cristian>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kossebau, mk-lists, simonandric5, stephane
Priority:	NOR
Version First Reported In:	5.1.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	5.2.0
Sentry Crash Report:

Description Cristian Oneț 2014-08-12 16:34:19 UTC

I'm getting these critical warnings for KStandardActions. I understand the reason to notify the application developer that he should set a default shortcut instead of the shortcut but this should not be done for standard actions or KActionCollection::addAction should properly set a default shortcut for standard actions. Either way the issue is in the KXmlGui framework.

Critical:Shortcut for action  "file_new" "&New" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.

Comment 1 Friedrich W. H. Kossebau 2014-08-31 16:44:09 UTC

Am also annoyed by those warning, enough to try a first approach to it with some patches:
* https://git.reviewboard.kde.org/r/120024/
* https://git.reviewboard.kde.org/r/120025/
* https://git.reviewboard.kde.org/r/120026/

Not sure this perfect solution yet, as I still miss the complete picture. But it might be one step into the right direction.

Comment 2 Cristian Oneț 2014-09-09 14:08:03 UTC

Fixed by https://git.reviewboard.kde.org/r/120088/ it's a shame that bug reports are not maintained.