| Summary: | Cancelling tags assigment in file metadata does not work [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | DrSlony <bugs> |
| Component: | ProgressManager-Usability | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, marcel.wiesweg, metzpinguin, veaceslav.munteanu90 |
| Priority: | NOR | ||
| Version: | 4.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/14f77f54d47de008a249360942449a4d04f60aa1 | Version Fixed In: | 4.12.0 |
| Sentry Crash Report: | |||
| Attachments: | cancelworker.patch | ||
|
Description
DrSlony
2014-08-11 17:01:14 UTC
Maik, In this file, the loop to process image with tags assignment is performed by FileActionMngr. See ImageDescEditTab::slotApplyAllChanges(). I check code in FileActionMngr and it's connected to Progress Manager. Can you reproduce the dysfunction ? Gilles Created attachment 93679 [details]
cancelworker.patch
With this patch, the write metadata to DB and files can be canceled.
Maik
Patch sound fine for me... But we must know the current talk between Veaceslav and Marcel about KF5 port dysfunctions from FileActionMngr. I CC you for info by private mail. Gilles MAik, I forwarded the thread between Veaceslav and Marcel. Did you manage to backport this patch to Frameworks branch ? Gilles Git commit 14f77f54d47de008a249360942449a4d04f60aa1 by Maik Qualmann. Committed on 21/07/2015 at 20:44. Pushed by mqualmann into branch 'master'. apply patch #93679 to writing the metadata to the DB and the files can be canceled FIXED-IN: 4.12.0 M +2 -1 NEWS M +39 -0 app/fileaction/databaseworkeriface.cpp M +11 -2 app/fileaction/fileactionmngr_p.cpp M +1 -0 app/fileaction/fileactionmngr_p.h M +19 -0 app/fileaction/fileworkeriface.cpp http://commits.kde.org/digikam/14f77f54d47de008a249360942449a4d04f60aa1 Git commit 5493e5b912c4b2c9df0fc1cb05539fd542e5129d by Maik Qualmann. Committed on 29/07/2015 at 17:11. Pushed by mqualmann into branch 'frameworks'. backport commit #14f77f54d47de008a249360942449a4d04f60aa1 from git/master to frameworks branch M +39 -0 libs/fileactionmanager/databaseworkeriface.cpp M +11 -2 libs/fileactionmanager/fileactionmngr_p.cpp M +1 -0 libs/fileactionmanager/fileactionmngr_p.h M +19 -0 libs/fileactionmanager/fileworkeriface.cpp http://commits.kde.org/digikam/5493e5b912c4b2c9df0fc1cb05539fd542e5129d |