Bug 337121

Summary: Font dialog's sample text should be translatable
Product: [Applications] konsole Reporter: Alexander Potashev <aspotashev>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED NOT A BUG    
Severity: normal CC: cpigat242
Priority: NOR    
Version: 2.99.900   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Alexander Potashev 2014-07-05 18:28:19 UTC
The text for "sampleText" in EditProfileDialog::showFontDialog() should be translatable, at least partially, for example in "ell 'lL', one '1', little eye 'i', big eye" the descriptions "ell", "one", "little eye" and "big eye" are probably unclear for non-English speakers. Please wrap these strings in i18n() calls.

Reproducible: Always




1. Tested on KF5 version from Project Neon5 build of July 5, 2014 (today).

2. The change of font dialog's sample text was introduced in this commit:

commit aa9f6ccc957972c3c7250db8d3f978db0b2f9a7d
Refs: v4.7.95-68-gaa9f6cc
Author:     Kurt Hindenburg <kurt.hindenburg@gmail.com>
AuthorDate: Sun Jan 1 16:16:49 2012 -0500
Commit:     Kurt Hindenburg <kurt.hindenburg@gmail.com>
CommitDate: Sun Jan 1 16:24:18 2012 -0500

    Change the font dialog's sample text for terminal usage.

    Use the code provided by Thomas Lübking in
    https://git.reviewboard.kde.org/r/103357/ to change the font dialog's
    sample text.  Since the text entry is large I added a lot of text
    that some fonts may appears too similiar in the terminal.
---
 src/EditProfileDialog.cpp | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Comment 1 Kurt Hindenburg 2017-02-13 00:19:56 UTC
The new font dialog doesn't use this sample text any longer