Bug 336683

Summary:	Updated holiday file for Italy (Italian) (with multiple categories for each event)
Product:	[Applications] kdepimlibs	Reporter:	Luigi Toscano <luigi.toscano>
Component:	kholidays	Assignee:	John Layt <jlayt>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	kdepim-bugs, winter
Priority:	NOR
Version:	GIT (master)
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/kholidays/bcff6c8e5a658c27325fe20959d31aef72c93a17	Version Fixed In:
Sentry Crash Report:
Attachments:	Updated holiday file for Italy (Italian)

Description Luigi Toscano 2014-06-24 22:44:29 UTC

Created attachment 87386 [details]
Updated holiday file for Italy (Italian)

Updated Italy-Italian holidays file. Changelog from the patch (generated with git format-patch, ready to be applied if it passes the review):

- add "religious" when appropriate to many "public" days
- add "commemorative" when appropriate to public and cultural days
- split Ascension date to the proper one vs the one mostly celebrated in Italy (see bug#329285)
- split "Festa della Repubblica" which was not "public" (commemorative only) before 2001
- move "Festa dell'Unità nazionale" to commemorative (end of WWI)

Comment 1 Allen Winter 2015-09-05 20:25:31 UTC

Luigi,

This patch has been sitting for over a year.  I know holidays can change so I ask if this patch is still valid?  If so, I will commit it.

Comment 2 Luigi Toscano 2015-09-05 21:53:02 UTC

The content of the patch is still current. If the patch is syntactically valid, please commit it (or I can do it).

Comment 3 Allen Winter 2015-09-05 23:47:34 UTC

yes, looks fine.
please commit.

Comment 4 Luigi Toscano 2015-09-05 23:59:34 UTC

Git commit bcff6c8e5a658c27325fe20959d31aef72c93a17 by Luigi Toscano.
Committed on 05/09/2015 at 23:58.
Pushed by ltoscano into branch 'master'.

Updated holiday file for Italy (Italian)

- add "religious" when appropriate to many "public" days
- add "commemorative" when appropriate to public and cultural days
- split Ascension date to the proper one vs the one mostly celebrated
  in Italy (see bug#329285)
- split "Festa della Repubblica" which was not "public" (commemorative
  only) before 2001
- move "Festa dell'Unità nazionale" to commemorative (end of WWI)

M  +19   -14   holidays/plan2/holiday_it_it

http://commits.kde.org/kholidays/bcff6c8e5a658c27325fe20959d31aef72c93a17

Comment 5 Luigi Toscano 2015-09-06 00:00:46 UTC

Pushed to the standalone kholidays library-but-not-yet-framework. I guess it's pointless to backport it to kdepimlibs KDE/4.14, which is not released anymore.