| Summary: | Tooltips don't adapt the size to the correct unit | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Aleix Pol <aleixpol> |
| Component: | Folder | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | mklapetek |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-desktop/e0aa5eaac8347b3c05977742fc8df31a957f46c0 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Aleix Pol
2014-06-19 17:44:48 UTC
This is a vague bug report - is the issue generally not using human-friendly units? That's because QML's Locale type has no formatter for it[1], the QML wrapper around KLocale's method[2] was removed in KF5 and it's not economical to do this leg work in Folder right now. Hopefully QML's Locale stuff will improve in the future. 1 = http://doc-snapshot.qt-project.org/qt5-5.3/qml-qtqml-locale.html 2 = http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKLocale.html#a3116ebc59ad98cbf80dc06ff9489e330 Yes, it's not human-friendly units. Actually the Folder View is only going to be used by humans, for the moment. The fact that we can't fix it now doesn't mean this is not a problem. I have a patch ready, waiting for Eike to approve. Git commit e0aa5eaac8347b3c05977742fc8df31a957f46c0 by Martin Klapetek. Committed on 19/06/2014 at 18:38. Pushed by mklapetek into branch 'master'. [folder] Format file sizes in tooltip using KFormat Reviewed-by: Eike Hein M +2 -1 containments/folder/package/contents/ui/ItemDelegate.qml http://commits.kde.org/plasma-desktop/e0aa5eaac8347b3c05977742fc8df31a957f46c0 |