| Summary: | Plasmoid Settings: Icon not aligned with text in the Cancel button | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Aleix Pol <aleixpol> |
| Component: | general | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bhush94, kde, notmart |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-desktop/177ba4e5d10f788f267791ca5782e44ae861df64 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | detail of the displayed buttons | ||
Note: it happens both when using Oxygen and QtCurve&Breeze. so should be an upstream report? Maybe, assigning to david edmundson who is the person to figure it out. David? Is it any different in oxygen-demo? To me it looks the same. Git commit 177ba4e5d10f788f267791ca5782e44ae861df64 by David Edmundson. Committed on 11/07/2014 at 10:25. Pushed by davidedmundson into branch 'Plasma/5.0'. Remove completley wrong changes to ToolboxButton Adapt iconsize to toolbox size introduces a blatant binding loop It was changed to be 0.8 of the frame, but the frame was based on the icon size The binding loop was then "fixed" by wrapping in an item which doesn't fix the root problem of it being a loop. The iconSize comes from units.iconSize.Small in ToolBoxRoot in the first place, making the entire change pointless. If we do want to scale the icon we just need to change that one line in ToolBoxRoot. We certainly don't want to make changes that leave stray unused properties about. Revert "remove undetected binding loop" This reverts commit eddb56e5a7cac3cd631f1cb8e315af02f57779ee. Revert "use standard icons sizes for the toolbox icon" This reverts commit 216ee387648f7105561dabcf33d06ec880be65a3. Revert "Adapt icon size to toolbox size" This reverts commit e38dc4f0dadd5ca40f34e4ba538eedd23c594e92. Related: bug 337055 REVIEW: 119229 M +16 -34 toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml http://commits.kde.org/plasma-desktop/177ba4e5d10f788f267791ca5782e44ae861df64 |
Created attachment 87286 [details] detail of the displayed buttons Probably a bug in QtQuick Controls that we want to fix. The Icon and the text are unaligned to each other. See attachment