Summary: | autocompletion shows multiple entries for one contact with different quotes | ||
---|---|---|---|
Product: | [Applications] kmail2 | Reporter: | Sandro Knauß <sknauss> |
Component: | composer | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mollekopf |
Priority: | NOR | ||
Version: | Git (master) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kdepim/84a0945c2e0c00de317de50e7f0c9e0156d08071 | Version Fixed In: | 14.12.3 |
Attachments: | patch from the kolab branch |
Description
Sandro Knauß
2014-06-13 09:45:44 UTC
Note that the problem is not necessarily that multiple entires are shown (as covered by 316036), but rather that entires make it into the selection that are not actually valid email addresses, causing the email to be rejected by the server. One reason is possibly faulty indexing of the addresses, perhaps there are others. In any case it probably would make sense to ensure a selected email address is valid before copying into the mail, or even hiding it completely from the selection. From the rfc excerpt I take a name has to be quoted if it contains spaces, otherwise not. So valid would be: "John Doe" <john@doe.com> John <john@doe.com> Created attachment 90368 [details]
patch from the kolab branch
Well at least I have created a patch, so actually if someone wants to take care to get it into- feel free. Otherwise it will come into kdepim if other patches from kolab will enter kdepim. Git commit 84a0945c2e0c00de317de50e7f0c9e0156d08071 by Montel Laurent. Committed on 04/02/2015 at 08:33. Pushed by mlaurent into branch 'KDE/4.14'. Fix Bug 336163 - autocompletion shows multiple entries for one contact with different quotes Adapt patch from Sandro Knauß to new baloocompletionemail class + unittest etc. FIXED-IN: 14.12.3 M +1 -1 libkdepim/addressline/autotests/CMakeLists.txt M +10 -0 libkdepim/addressline/autotests/baloocompletionemailtest.cpp M +1 -0 libkdepim/addressline/autotests/baloocompletionemailtest.h M +40 -3 libkdepim/addressline/baloocompletionemail.cpp M +2 -1 libkdepim/addressline/baloocompletionemail.h http://commits.kde.org/kdepim/84a0945c2e0c00de317de50e7f0c9e0156d08071 |