Bug 334408

Summary:	Brush outline has bad visibility and shape
Product:	[Applications] krita	Reporter:	arturrataj
Component:	Brush engines	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dimula73, halla
Priority:	NOR
Version:	2.8.2
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/31a82094e2413188c75c00983424459787ab1ed5	Version Fixed In:
Sentry Crash Report:

Description arturrataj 2014-05-06 10:29:35 UTC

Brush outline shortcuts two of the segments of the otline with a single segment. So a single pixel brush has the outline of a triangle, etc. Also, when not in OpenGL mode, it seems that the common point of two adjacent segments is invisible, probably due to double negation. It gives poor visibility if the canvas zoom is not high.


Reproducible: Always

Steps to Reproduce:
1. Choose a brush with a known, simple shape.
2. If not in OpenGL mode, the outline behaves strangely and has visibility problems.
2. Zoom--in the canvas, until pixels are visible as clear rectangles.
3. See the shortcutted segments.


Expected Results:  
Outline having the exact shape of the brush, and no double color negation.

Comment 1 Halla Rempt 2014-05-07 14:37:05 UTC

Yes, I can confirm the little triangle effect.

Comment 2 Dmitry Kazakov 2014-05-07 17:29:08 UTC

I have fixed the bug today locally, now I just need a bit of cleanup.

Comment 3 Dmitry Kazakov 2014-05-08 10:30:10 UTC

Git commit d77d384df606af304103ff84de9a26bb9c81472e by Dmitry Kazakov.
Committed on 08/05/2014 at 09:53.
Pushed by dkazakov into branch 'master'.

Fix a triangular brush outline for a 1px brush

This patch also fixes major code duplications in the
KisOutlineGenerator. Now everything is templated.

M  +108  -155  krita/image/kis_outline_generator.cpp
M  +15   -5    krita/image/kis_outline_generator.h

http://commits.kde.org/calligra/d77d384df606af304103ff84de9a26bb9c81472e

Comment 4 Halla Rempt 2014-05-10 09:10:21 UTC

Git commit 31a82094e2413188c75c00983424459787ab1ed5 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 08/05/2014 at 09:53.
Pushed by rempt into branch 'calligra/2.8'.

Fix a triangular brush outline for a 1px brush

This patch also fixes major code duplications in the
KisOutlineGenerator. Now everything is templated.

M  +108  -155  krita/image/kis_outline_generator.cpp
M  +15   -5    krita/image/kis_outline_generator.h

http://commits.kde.org/calligra/31a82094e2413188c75c00983424459787ab1ed5