Bug 333256

Summary:	Pawn Promotion Incorrect In Xboard Protocol
Product:	[Applications] knights	Reporter:	Dave Kaye <d_k>
Component:	general	Assignee:	Miha Čančula <miha>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde-games-bugs-null
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Other
Latest Commit:	http://commits.kde.org/knights/2f92ba88ac66baeaf1865b989dde03b556144cae	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch for bug 333256

Description Dave Kaye 2014-04-10 00:55:20 UTC

The string sent to a chess engine using Xboard protocol is for example e7e8=Q    This will work with a number of chess engines.  However the Xboard specification is e7e8q   This will work with more chess engines.

Reproducible: Always

Comment 1 Dave Kaye 2014-04-12 17:37:49 UTC

Created attachment 86060 [details]
Patch for bug 333256

This code should work on both the 2.5 and 2.4 versions of Knights.

It will cause the pawn promotion to be sent as e7e8q.  It was developed from the uci code.

Comment 2 Alexander Semke 2016-03-13 10:22:47 UTC

Git commit 2f92ba88ac66baeaf1865b989dde03b556144cae by Alexander Semke.
Committed on 13/03/2016 at 10:21.
Pushed by asemke into branch 'master'.

Fixed incorrect pawn promotion in the Xboard protocol

Code cleanup in XBoardProtocol.

M  +244  -317  src/proto/xboardprotocol.cpp
M  +59   -55   src/proto/xboardprotocol.h

http://commits.kde.org/knights/2f92ba88ac66baeaf1865b989dde03b556144cae