Bug 332931

Summary:	KWallet API still tries to invoke kwalletd when user disabled kde wallet in system settings
Product:	[Unmaintained] kdelibs	Reporter:	Valentin Rusu <valir>
Component:	kwallet	Assignee:	Valentin Rusu <valir>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	234440, 322964, 327086

Description Valentin Rusu 2014-04-01 22:35:00 UTC

The system settings KCM for KWallet offer users a check-box labeled "Enable the KDE wallet subsystem". While that check-box is correctly modifying kwalletrc, the KWallet API (kwallet.h) seems to incorrectly handle the case where the user disabled this subsystem.

Expected behavior: the openWallet (mainly) and the other methods of the KWallet class should gracefully fail when the KDE wallet subsystem is not enabled.

Actual situation: only a warning is issued, visible only when built in DEBUG mode and only in the console output of the KWallet API client application. Further inspection shows that all the API go ahead and call the dbus service. But kwalletd itself quits if it founds the disable flag upon launch, leading to an unpredictable results situation.

Reproducible: Always





BUG 328178 provide a link to this forum thread:
https://www.kubuntuforums.net/showthread.php?63690-Kwallet-problems-keep-me-out-of-Kmail

That forum thread show that this can be quite annoying for our users.

Comment 1 Valentin Rusu 2015-11-28 16:17:08 UTC

This will make kwalletd exit when user deactivates the wallet:
http://commits.kde.org/kwallet/3e437fdc743f8855bd047afb780059d68580776e

Comment 2 Valentin Rusu 2015-11-28 18:22:54 UTC

See commit: e2b3c919e699ec