| Summary: | Support loading kgraphviewer via KPluginFactory | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] massif-visualizer | Reporter: | Reimar Döffinger <kde> |
| Component: | general | Assignee: | Arnold Dumas <contact> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | contact |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 0.2 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/massif-visualizer/c5a03f76e353dbff0755d72ede9fc450fc343082 | Version Fixed In: | |
| Sentry Crash Report: | |||
Git commit c5a03f76e353dbff0755d72ede9fc450fc343082 by Arnold Dumas. Committed on 22/04/2014 at 21:45. Pushed by arnolddumas into branch 'master'. Support loading kgraphviewer via KPluginFactory. REVIEW: 117375 M +4 -4 app/documentwidget.cpp M +6 -4 app/mainwindow.cpp http://commits.kde.org/massif-visualizer/c5a03f76e353dbff0755d72ede9fc450fc343082 |
I removed use of the deprecated KLibFactory in kgraphviewer. This basically means you have to replace KLibFactory *factory = KLibLoader::self()->factory("kgraphviewerpart"); by KPluginFactory *factory = KPluginLoader("kgraphviewerpart").factory(); for it to still work. I hope that is ok, I expect it should be possible to support both in principle, but it would have been a lot of code and pain, so I'd prefer to just ask everyone to change their code. Please contact me if you have any concerns or would like me to handle this change in a different way. Reproducible: Always