| Summary: | Wrong location of documentation translations | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | nucleo <nucleo> |
| Component: | Documentation | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, kde, kevin.kofler, lueck, pino, rdieter |
| Priority: | NOR | ||
| Version: | 4.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/scratch/mwiesweg/digikam-sc/7b15383080188c8ceff1c4af0cbbb2f046578b73 | Version Fixed In: | 4.0.0 |
| Sentry Crash Report: | |||
| Attachments: | location fix | ||
|
Description
nucleo
2014-03-27 01:36:46 UTC
doc-translated/*/CMakeLists.txt has:
kde4_create_handbook( index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/et/ )
That should be:
kde4_create_handbook( index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/et/ SUBDIR digikam )
(of course, replace "et" by the respective language.)
(SUBDIR is required whenever the directory name in the tarball does not match the target directory name, i.e. typically for translated documentation.)
Created attachment 85779 [details] location fix Patch made from Comment 1. doc-translated subdir is new in beta4 tarball, it wasn't in beta3. Nicolas, Do you see this entry ? Gilles Caulier (In reply to comment #2) > Created attachment 85779 [details] > location fix > > Patch made from Comment 1. While the approach is correct, the patch is wrong since those files are autogenerated by a script in the digikam-software-compilation repository (project/release/fetch_l10n.rb). I am going to fix it properly now. Git commit 7b15383080188c8ceff1c4af0cbbb2f046578b73 by Pino Toscano. Committed on 30/03/2014 at 19:31. Pushed by pino into branch 'master'. fetch_l10n.rb: fix creation of CMakeLists.txt for doc translations M +1 -1 project/release/fetch_l10n.rb http://commits.kde.org/scratch/mwiesweg/digikam-sc/7b15383080188c8ceff1c4af0cbbb2f046578b73 Well, nucleo's patch fixed your release tarball. :-) But thanks for the fix to the script that generates your release files. :-) (In reply to comment #7) > Well, nucleo's patch fixed your release tarball. :-) Yes, I know what the patch does. > But thanks for the fix to the script that generates your release files. :-) Please drop the "your", since I'm not a digikam developer. thanks, we will have this fixed for rc then, or do i need to respin the tarball ? ( like a beta4.1 tarball ) @Nivolas, No need, 4.0.0-RC is planed in 2 weeks. Gilles |