Summary: | System tray shows media controller twice | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Bhushan Shah <bhush94> |
Component: | Media Player widget | Assignee: | Martin Klapetek <mklapetek> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alex.merry, kde, notmart, sebas |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/plasma-workspace/f18ef033332d27a060e5db37f99ce359796f4d61 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: | screenshot |
Adding sebas in CC as it is related to system tray Do you have two mediaplayers running? Which player are you using? I am running VLC and only one time make sure your installation is clear and you don't actually have 2 media controllers installed with a different name I am sure with that thing, as yesterday I clean installed everything. For ref, Listing service types: Plasma/Applet, Plasma/Containment org.kde.desktopcontainment org.kde.example.bugreport org.kde.example.conditionalloader org.kde.example.configuration org.kde.example.dataenginemodel org.kde.example.notes org.kde.example.tasks org.kde.example.testcomponents org.kde.example.testcontainment org.kde.example.testshaders org.kde.example.testtheme org.kde.example.widgetgallery org.kde.example.windowthumbnails org.kde.examples.compactrepresentation org.kde.examples.helloworld org.kde.panel org.kde.plasma.activitybar org.kde.plasma.analogclock org.kde.plasma.battery org.kde.plasma.calendar org.kde.plasma.devicenotifier org.kde.plasma.digitalclock org.kde.plasma.icon org.kde.plasma.kickoff org.kde.plasma.mediacontroller org.kde.plasma.notifications org.kde.plasma.pager org.kde.plasma.panelspacer org.kde.plasma.showActivityManager org.kde.plasma.systemtray org.kde.plasma.taskmanager org.kde.plasma.trash org.kde.plasma.windowlist org.kde.systrayplasmoidtest org.kde.tests.background Can you make sure you delete your plasma configs too. Do you have any special settings in VLC? I don't see any mpris setting in there and it's not on the bus Oh interesting. I can now reproduce with VLC and its mpris interface. Will look. Since you are already there, please see that plasmoid is not correctly working with VLC. it is not showing name.. check screenshot. Investigation results: VLC exports two mpris interfaces on dbus, but they're still the same object with the same dbus unique address Solution is to implement a hash of dbus addresses and the interface names and then just check if we already have a container for that dbus address. Git commit f18ef033332d27a060e5db37f99ce359796f4d61 by Martin Klapetek. Committed on 01/04/2014 at 18:12. Pushed by mklapetek into branch 'master'. Fix mediacontroller showing twice for VLC There's a more correct fix to that (see the comment in the diff) but given the situation, it's just much easier to go with this way. Reviewed-by: David Edmundson M +18 -0 dataengines/mpris2/mpris2engine.cpp http://commits.kde.org/plasma-workspace/f18ef033332d27a060e5db37f99ce359796f4d61 |
Created attachment 85733 [details] screenshot one active and one passive