Bug 332280

Summary: freerotationfilter.cpp:92: (style) Same expression on both sides of '||'.
Product: [Applications] digikam Reporter: dcb314
Component: Albums-FiltersAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version First Reported In: 4.0.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/5ac520779fce2238610e07936ca8ecaa7802a177 Version Fixed/Implemented In: 4.0.0
Sentry Crash Report:

Description dcb314 2014-03-18 12:34:32 UTC 
Source code is

    if (p1.x() < 0 ||
        p2.y() < 0 ||
        p1.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

Maybe something like

    if (p1.x() < 0 ||
        p1.y() < 0 ||
        p2.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

was intended.
Comment 1 caulier.gilles 2014-03-18 12:49:28 UTC 
Git commit 5ac520779fce2238610e07936ca8ecaa7802a177 by Gilles Caulier.
Committed on 18/03/2014 at 12:47.
Pushed by cgilles into branch 'master'.

fix comparison arguments in head of calculateAngle fonction
FIXED-IN: 4.0.0

M  +22   -24   libs/dimg/filters/transform/freerotationfilter.cpp
M  +5    -5    libs/dimg/filters/transform/freerotationfilter.h

http://commits.kde.org/digikam/5ac520779fce2238610e07936ca8ecaa7802a177