| Summary: | Popups in plasma-shell creates entry named plasma_shell in task manager and then deletes entry | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Bhushan Shah <bhush94> |
| Component: | libplasmaquick | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, gaantonio, hein, hrvoje.senjan, kde, mgraesslin, mklapetek, n.schnelle, notmart, Ondrej.Machulda, tromzy |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-framework/42e924e7f61e7b36266e6c3ca07aa414e88f50ca | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Animated gif that shows problem | ||
i think the culript is that qt does set its own states, then we have to overwrite them, but it's after the window has been shown, so there is a little instantflags are wrong :/ this one is resolved i think, for a few days at least (In reply to comment #2) > this one is resolved i think, for a few days at least hmm, no at first taskbar entry was visible but now it is not visible normally but gets created and gets destroyed too fast.. I can reproduce only with Kickoff, it does indeed get created and removed really fast. Confirming. seems that qt resets the window flags at the wrong moment, probably not much we can do about (In reply to comment #5) > seems that qt resets the window flags at the wrong moment, probably not much > we can do about well there are few things which come to my mind: * fix Qt (implement all the flags we need) * don't create the taskbar entry instantly but wait a little bit to get updates so? ping! I can still see this sometimes when opening kickoff after logging in Still a thing in latest master. Given Martin's comment in #6 -- "* don't create the taskbar entry instantly but wait a little bit to get updates" -- this might sort it out, so I'm adding Eike to CC for comments. That would have to be a last resort, IMHO. Adding magic value delays to the system decreases its responsiveness and increases its complexity by no longer simply directly representing state. It also tends to be very hard to take magic timers out again once they're there, starting with anybody having to know they're there. The TM has to be pragmatic sometimes and work around others' crap, but an exception for every Plasma popup - our own windows - doesn't sit right. *** Bug 345890 has been marked as a duplicate of this bug. *** *** Bug 347354 has been marked as a duplicate of this bug. *** Somewhat directly related bug caused by this -- https://bugs.kde.org/show_bug.cgi?id=352278 *** Bug 354608 has been marked as a duplicate of this bug. *** *** Bug 356510 has been marked as a duplicate of this bug. *** Any news about this bug? For me this ghost entry is very visible and makes taskbar/panel to flicker/flash. Video: https://www.dropbox.com/s/iznqz20ukq4v3cq/2016-01-13%2013.09.04.mp4?dl=0 Git commit 42e924e7f61e7b36266e6c3ca07aa414e88f50ca by David Edmundson. Committed on 15/03/2016 at 14:34. Pushed by davidedmundson into branch 'master'. Fix taskbar flicking when opening Plasma popups When we show a Qt window it resets all wm_states, including the SKIP_TASKBAR state that Qt doesn't support see QXcbWindow::setNetWmStates In order to set the flag we need to do it after Qt has mapped the window. This was previously done using ExposeEvent which will happen after show, but by it being a separate event the task manager will get notified in the meantime. By merging into the same event we can make sure the flag is set before the task manager processes it. REVIEW: 127374 M +13 -4 src/plasmaquick/dialog.cpp http://commits.kde.org/plasma-framework/42e924e7f61e7b36266e6c3ca07aa414e88f50ca Git commit 28b4400da8481251084ac38b26b4347703a3ab54 by David Rosca. Committed on 19/03/2016 at 08:02. Pushed by drosca into branch 'master'. Dialog: Set SkipTaskbar/Pager states before showing window This sets the states before showing the window and is a proper fix for the linked bug. Needs e4cea305ed2ba3c9f580bf9d16c59a1048af0e8a from qtbase - Qt 5.6.1 REVIEW: 127422 M +4 -0 src/plasmaquick/dialog.cpp http://commits.kde.org/plasma-framework/28b4400da8481251084ac38b26b4347703a3ab54 |
Created attachment 85529 [details] Animated gif that shows problem This happens so fast it is not visible but I managed to create animated gif for it