| Summary: | Show Seconds config option does not actually alter whether seconds are shown | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | David Edmundson <kde> |
| Component: | Digital Clock | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/7a7ca1e18f5d96799913f4854176aea422ee3848 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 328586 | ||
Works fine here. Even tried with different locales - en_US, en_GB and cs_CZ are all fine. What's your locale? Can you put "print(timeFormatString);" after line 148 and post the output please? at start of function HH:mm:ss at end of function HH:mm:ss t oh! my short format is providing seconds. So I never hit your crazy regex which adds them. and there's no code to remove it if they're not meant to be on. How do I find out my locale? Interesting. I checked the full list of locales on my system, none of them was returning :ss so I assumed it would be safe. You can print Qt.locale().uiLanguages - the first one should be your current locale. That returned one thing. "[C]" C is the POSIX locale, Qt(Quick) sets it when it gets an invalid locale passed to it, basically it's a fallback and should never be used as default. Means your system is misconfigured. But I'll extend the code to handle this case too. Git commit 7a7ca1e18f5d96799913f4854176aea422ee3848 by Martin Klapetek. Committed on 06/02/2014 at 17:44. Pushed by mklapetek into branch 'master'. [plasma/digital-clock] Make sure we don't show seconds when disabled REVIEW: 115513 M +5 -0 plasma/generic/applets/digital-clock/contents/ui/DigitalClock.qml http://commits.kde.org/kde-workspace/7a7ca1e18f5d96799913f4854176aea422ee3848 |
Show Seconds config option does not actually alter whether seconds are shown. It does update the dataengine refresh timing so the config part is working. function timeFormatCorrection(timeFormatString) must be broken.