Summary: | [Patch] Add support for Unity quicklists to Konsole | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Ivo Anjo <ivo> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/115400/ | ||
Latest Commit: | http://commits.kde.org/konsole/b18b1b306fc1adb6c8a32363669d82a7355ca485 | Version Fixed In: |
Description
Ivo Anjo
2014-01-30 14:10:56 UTC
Patch added on reviewboard: https://git.reviewboard.kde.org/r/115400/ Git commit 4ef99992da2a409967160048696283541a8e7dfe by Kurt Hindenburg. Committed on 04/02/2014 at 15:06. Pushed by hindenburg into branch 'master'. Add support for Unity quicklist Thanks to Ivo Anjo knuckles@gmail.com The translations are not included - we'll let them get translated the normal KDE way. Please verify this works as I don't have a way of testing. REVIEW: 115400 M +6 -0 desktop/konsole.desktop http://commits.kde.org/konsole/4ef99992da2a409967160048696283541a8e7dfe Git commit b18b1b306fc1adb6c8a32363669d82a7355ca485 by Kurt Hindenburg. Committed on 04/02/2014 at 15:06. Pushed by hindenburg into branch 'frameworks'. Add support for Unity quicklist Thanks to Ivo Anjo knuckles@gmail.com The translations are not included - we'll let them get translated the normal KDE way. Please verify this works as I don't have a way of testing. REVIEW: 115400 (cherry picked from commit 4ef99992da2a409967160048696283541a8e7dfe) M +6 -0 desktop/konsole.desktop http://commits.kde.org/konsole/b18b1b306fc1adb6c8a32363669d82a7355ca485 (In reply to comment #3) > Please verify this works as I don't have a way of testing. Sorry, I forgot to reply, but I can confirm it's working nicely, thanks! And thanks for committing this. I was actually sitting on it for a long time, manually adding it to all my machines because I thought it might not be acceptable upstream -- I've had some bad experiences before with small should-go-in-directly-but-are-ignored patches. Thanks! It seems that in the latest desktop spec this has been removed https://bugs.freedesktop.org/show_bug.cgi?id=66712 http://lists.freedesktop.org/archives/xdg/2013-July/012835.html desktop/konsole.desktop: key "OnlyShowIn" in group "Desktop Action NewWindow" is deprecated (In reply to comment #5) > It seems that in the latest desktop spec this has been removed > > https://bugs.freedesktop.org/show_bug.cgi?id=66712 > http://lists.freedesktop.org/archives/xdg/2013-July/012835.html > > desktop/konsole.desktop: key "OnlyShowIn" in group "Desktop Action > NewWindow" is deprecated I copied from the ones Firefox had. But I don't think removing that key would have any issues, the rationale seems to make sense. Git commit 4b69f9125a7e0f6ac9f014a49047b17dc0db196d by Kurt Hindenburg. Committed on 16/02/2014 at 23:52. Pushed by hindenburg into branch 'master'. Remove OnlyShowIn as it is depreciated in the latest desktop spec M +0 -1 desktop/konsole.desktop http://commits.kde.org/konsole/4b69f9125a7e0f6ac9f014a49047b17dc0db196d Git commit 4e323d11475aea3000b218e8eaf761acb5859732 by Kurt Hindenburg. Committed on 16/02/2014 at 23:52. Pushed by hindenburg into branch 'frameworks'. Remove OnlyShowIn as it is depreciated in the latest desktop spec (cherry picked from commit 4b69f9125a7e0f6ac9f014a49047b17dc0db196d) M +0 -1 desktop/konsole.desktop http://commits.kde.org/konsole/4e323d11475aea3000b218e8eaf761acb5859732 |