Summary: | Smudge Rate controls the opacity of the final dab, not of the picked background, which results in nothing being painted when Smudge Rate is 0. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Bollebib <kwadraatnope> |
Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | animtim, halla, info |
Priority: | NOR | ||
Version: | 2.8 Beta | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Other | ||
Latest Commit: | http://commits.kde.org/calligra/62529fba596a99555c2373ad790d0042057083ad | Version Fixed In: | |
Attachments: | Screenshot : Krita SmudgeRate (top) ; Mypaint SmudgeLength (bottom) |
Description
Bollebib
2014-01-03 11:06:35 UTC
A few infos on this topic: -This has always worked this way (so if really a bug, it's always been there) -This is not specific to Dulling mode, it does the same for Smearing mode. -I remember I thought about this when working on the color smudge presets, and in the end I think it's not really a bug, as Smudge Rate controls the global "quantity of smudge" and color rate controls how much selected-color is added/mixed in this smudge.. I believe that having it working another way would not allow the same brush effect as we have currently. And so if I need a brush without smudge at all (which I guess would be what you expect of a brush with max.smudge set to 0 as described in this case), better use a pixel brush which will have more options and probably more optimised performances. Yes, actual 'Smudge Rate' slider affect final dab this way. As Animtim said, this is not really a bug. Just the design of the brush engine 'as it is now'. The expectation of Bollebib is probably to have more control in the 'amount of Smudge' or 'Smudge Power' , 'Smudge Lenght' ? Something the actual 'Smudge Rate' can't obviously do. This is a legit observation of the limitation of the current system. But definitely a [Wish] ( not a bug ) . And it will need documentations and references to describe the desired effect. Created attachment 84465 [details]
Screenshot : Krita SmudgeRate (top) ; Mypaint SmudgeLength (bottom)
After a bit of research ( attachement ) ; it appears 2 possible fix :
1) Label :
========
"krita Smudge Rate" = "mypaint Smudge Length" ( attachement ). So, for consistency in the label , renaming 'Smudge Rate' to 'Smudge Length' sounds better.
2) The 0.00 non effect should be non-possible
======================================
The slider should prevent user to do a 'non stroke' by making not accessible 0.00 value. ( ex; by making 0 behave as actual 0.01 ).
Git commit 4d4608e50ae7433e12544b71b332bd7377ea5c15 by Boudewijn Rempt. Committed on 06/01/2014 at 10:03. Pushed by rempt into branch 'calligra/2.8'. And set the minimum value of the smudge length to 0.1 M +1 -1 krita/plugins/paintops/colorsmudge/kis_colorsmudgeop_settings_widget.cpp M +4 -1 krita/plugins/paintops/colorsmudge/kis_smudge_option.cpp http://commits.kde.org/calligra/4d4608e50ae7433e12544b71b332bd7377ea5c15 Git commit 62529fba596a99555c2373ad790d0042057083ad by Boudewijn Rempt. Committed on 06/01/2014 at 10:03. Pushed by rempt into branch 'master'. And set the minimum value of the smudge length to 0.1 M +1 -1 krita/plugins/paintops/colorsmudge/kis_colorsmudgeop_settings_widget.cpp M +4 -1 krita/plugins/paintops/colorsmudge/kis_smudge_option.cpp http://commits.kde.org/calligra/62529fba596a99555c2373ad790d0042057083ad Hi Boud, Thanks for the commit above :) I noticed a little typo in the commit ; "Set the minimum value of the smudge length to 0.1" should not be 0.1 but 0.01 ; there is still room for interresting effect within the 0.01 to 0.10 range of smudge length. |