Summary: | mymoneystatementreader.cpp matching problem | ||
---|---|---|---|
Product: | [Applications] kmymoney | Reporter: | allan <agander93> |
Component: | general | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | git (master) | ||
Target Milestone: | --- | ||
Platform: | Mint (Ubuntu based) | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kmymoney/8c1f883fc302c639a5ee326ea226b2daf5a7a105 | Version Fixed In: |
Description
allan
2013-11-26 22:50:00 UTC
Not having an OFX source, I tested using the CSV importer, expecting that this was a reasonable approach because the provided patch was to code common to all import sources. However, whereas the user received a message box, indicating that the transaction would be dropped because no security was found, this did not happen with CSV. Instead, a new security was created. This was traced to MyMoneyStatementReader::processSecurityEntry line 497 - "} else if ((*it).tradingSymbol() == sec_in.m_strSymbol)" which was not finding a match because the two symbols were of different case, and '.toLower()' needed to be added to both sides. The CSV importer now produced the same message box as in OFX import. The immediate cause of this was that, at the point were the patch had been installed, the symbol there was empty. Finally, this was traced to void InvestProcessing::investCsvImport(MyMoneyStatement& st), where tr.m_strSymbol = (*it_s).m_strSymbol needed to be added. I'll be adding a patch for the full fix. The patch to fix this problem was committed in Git commit 22107d5c17f7a7c55b2abe0e09efc09c05e419a8 by Allan Anderson. Committed on 09/12/2013 at 21:58. Pushed by allananderson into branch 'master'. M +8 -3 kmymoney/converter/mymoneystatementreader.cpp M +1 -0 kmymoney/plugins/csvimport/investprocessing.cpp http://commits.kde.org/kmymoney/22107d5c17f7a7c55b2abe0e09efc09c05e419a8 BUG:327806 - Investment transactions dropped without notification during import. Git commit 8c1f883fc302c639a5ee326ea226b2daf5a7a105 by Allan Anderson. Committed on 18/12/2013 at 21:12. Pushed by allananderson into branch 'master'. Related: bug 328776 without assigning a brokerage or checking account. Also, improve wording of heading label of symboltabledlg.ui. M +6 -5 kmymoney/converter/mymoneystatementreader.cpp M +9 -4 kmymoney/plugins/csvimport/investprocessing.cpp M +1 -0 kmymoney/plugins/csvimport/investprocessing.h M +5 -3 kmymoney/plugins/csvimport/symboltabledlg.ui http://commits.kde.org/kmymoney/8c1f883fc302c639a5ee326ea226b2daf5a7a105 |