Bug 327863

Summary:	PATCH: Magnifier proof of concept
Product:	[Applications] okular	Reporter:	howl
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aacid, oliver.sander
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	f22d9d28973713011114266e3c5d3235484a0d14	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Allow realy BIG pixmaps for document rendering Magnifying glass -- proof of concept

Description howl 2013-11-20 13:44:01 UTC

Hi there!

I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.

The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.

The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.

So the remaining question is, what is the status of this:
 core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
Is someone working on it?

Reproducible: Always

Comment 1 howl 2013-11-20 13:45:09 UTC

Created attachment 83653 [details]
Allow realy BIG pixmaps for document rendering

Comment 2 howl 2013-11-20 13:46:11 UTC

Created attachment 83654 [details]
Magnifying glass -- proof of concept

Comment 3 Albert Astals Cid 2013-11-20 18:04:28 UTC

reviewboard at https://git.reviewboard.kde.org/r/113973/

Comment 4 Oliver Sander 2015-03-17 16:26:37 UTC

I can't find the commit right now, but Okular nowadays does have a magnifying glass.  It's the 6th entry in the 'extras' menu.  Hence I propose to close this bug.

Comment 5 Laura David Hurka 2021-05-16 19:28:25 UTC

Oliver Sander 2015-03-17 16:26:37 UTC
> I can't find the commit right now, but Okular nowadays does have
> a magnifying glass.  It's the 6th entry in the 'extras' menu.
> Hence I propose to close this bug.
Done