Summary: | Not all photos from addressbook shows using fancy headers | ||
---|---|---|---|
Product: | [Applications] kmail2 | Reporter: | luisfe <luisfe> |
Component: | UI | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | montel |
Priority: | NOR | ||
Version: | 4.12 pre | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
luisfe
2013-11-19 20:25:05 UTC
1) Can't comment about it. If it's in nepomuk it must displaying it (as it displays other picture) 2) I confirm it. I saw this bug yesterday, there is a pb when we add another email it's not all the time indexed don't know why. 3) pb is that we have several same contact so how define which picture shows ? I take the first one when we search so in your case the caldav result. If the two same contact has 2 differents pictures which picture I display ? With respect to 2) I am not sure if it is a problem of not being indexed. If I change the default address, then the new default address shows the photo but the old default does not show the photo anymore. Concerning 3), from a user perspective that knows little about programming, I would expect one of the following behaviors: a) The system checks all the contacts containing the given email address until one with a photo is found. So it would show the first photo found, but if the firs contact does not have a photo will look for a second one. b) There would be an option to "only search photos in XXX resource". As a user, I may be happy having the photos in my local personal contacts, but I do not want to share the photos with google through gmail or my company exchange server. I am not sure if they are hard to implement or if the first approach consumes a lot of resources. I think that the real problem is that the same person can be "spread" among different contacts, the same person may have the diffferent email addresses and different people may share the same email address. b) I don't want it will add new setup etc. Not good for users. a) ok I can look at all address and put first contact which has a photo, but if there is 2 different photos ?:) 2) will investigate more. Thanks! I think that in a) taking the first picture found is fair enough. Git commit dd24c09c6af98572d733f9e518d89fb3b0501ee6 by Montel Laurent. Committed on 10/12/2013 at 08:00. Pushed by mlaurent into branch 'KDE/4.12'. Fix Bug 327831 - Not all photos from addressbook shows using fancy headers Now show photo when there is several address item. M +11 -1 messageviewer/header/contactdisplaymessagememento.cpp M +1 -0 messageviewer/header/contactdisplaymessagememento.h http://commits.kde.org/kdepim/dd24c09c6af98572d733f9e518d89fb3b0501ee6 I fixed 'a)' I have checked with various configurations and posibilities and photos do appear correctly. In my opinion the bug should be closed as fixed. Ok I close it |