| Summary: | kscreen crashes kde daemon | ||
|---|---|---|---|
| Product: | [Plasma] KScreen | Reporter: | Jiri Slaby <jirislaby> |
| Component: | libkscreen | Assignee: | Alex Fiestas <afiestas> |
| Status: | CLOSED FIXED | ||
| Severity: | crash | CC: | bugzilla, drorcohen, dvratil, gkokmdam, gladhorn, grgoffe, krissn, mikael.karlsson.ekero, robin |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | 1.0.1 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/libkscreen/1d9ac012e857036bb8814cc84c9cf10bb57ca40c | Version Fixed/Implemented In: | 1.0.2 |
| Sentry Crash Report: | |||
| Attachments: | kscreen-console bug | ||
|
Description
Jiri Slaby
2013-09-07 17:50:25 UTC
If I had asserts enabled, I would hit this perhaps:
Q_ASSERT_X(currentMode, "applyKScreenConfig", "currentOutput has returned a null XRandRMode*");
Now building with (however it is incorrect):
--- a/backends/xrandr/xrandrconfig.cpp
+++ b/backends/xrandr/xrandrconfig.cpp
@@ -165,6 +165,9 @@ void XRandRConfig::applyKScreenConfig(KS
XRandRMode* currentMode = currentOutput->currentMode();
Q_ASSERT_X(currentMode, "applyKScreenConfig", "currentOutput has returned a null XRandRMode*");
+ if (!currentMode)
+ continue;
+
QSize size = currentMode->size();
int x, y;
(In reply to comment #1) > Now building with (however it is incorrect): Yup, it allows me to work again... *** Bug 323274 has been marked as a duplicate of this bug. *** *** Bug 324542 has been marked as a duplicate of this bug. *** Can you please provide output from "kscreen-console bug" ? Created attachment 82235 [details] kscreen-console bug (In reply to comment #5) > Can you please provide output from "kscreen-console bug" ? Is it enough from the fixed setup? . Git commit 1d9ac012e857036bb8814cc84c9cf10bb57ca40c by Dan Vrátil. Committed on 09/09/2013 at 16:43. Pushed by dvratil into branch 'master'. Refresh modes when currentModeId points to unknown mode Sometimes drivers insert or remove modes, so when currentModeId points to a mode that we don't have cached, we must refresh the local cache. This also fixes a crash that occured when currentModeId would be pointing to a mode that we don't have (even after refreshing modes) REVIEW: 112604 Related: bug 323107 FIXED-IN: 1.0.2 M +43 -20 backends/xrandr/xrandrconfig.cpp M +15 -0 backends/xrandr/xrandrmode.cpp M +4 -0 backends/xrandr/xrandrmode.h M +5 -0 backends/xrandr/xrandroutput.cpp M +3 -1 backends/xrandr/xrandroutput.h http://commits.kde.org/libkscreen/1d9ac012e857036bb8814cc84c9cf10bb57ca40c *** Bug 327716 has been marked as a duplicate of this bug. *** *** Bug 325900 has been marked as a duplicate of this bug. *** *** Bug 327965 has been marked as a duplicate of this bug. *** *** Bug 327966 has been marked as a duplicate of this bug. *** *** Bug 334139 has been marked as a duplicate of this bug. *** |