Bug 323658

Summary:	no application icon in MS Windows for trojita.exe (patch attached)
Product:	[Applications] trojita	Reporter:	Christian Degenkolb <degenkolb>
Component:	Other	Assignee:	Trojita default assignee <trojita-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/trojita/c008b4d795886cb34667cea7c4947c15a3cd8e96	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	patch to add appliaction item support for MS Windows with VC2010

Description Christian Degenkolb 2013-08-17 21:33:47 UTC

Hi

there is no application item set for trijota.exe on MS Windows. The resulting exe gets the default icon. 

The patch fixes this for the current git in Windows with the MSVC2010 compiler.

Reproducible: Always

Steps to Reproduce:
1. Build trojita on Windows with Qt 4.8.5, cmake 2.8.11 and VC2010

Actual Results:  
trojita.exe has no application item in the windows file manager

Expected Results:  
there should be an application item, the trijota logo would be great for this. 

Since  couldn't find a way to attaché the patch on big report creation I will add it later.

Comment 1 Christian Degenkolb 2013-08-17 21:35:03 UTC

Created attachment 81761 [details]
patch to add appliaction item support for MS Windows with VC2010

I hope this patch is ok. The windows git client is confusing the hell out of me..

Comment 2 Jan Kundrát 2013-08-18 09:09:23 UTC

Git commit c008b4d795886cb34667cea7c4947c15a3cd8e96 by Jan Kundrát, on behalf of Christian Degenkolb.
Committed on 16/08/2013 at 18:59.
Pushed by jkt into branch 'master'.

GUI: add support for application icon on Windows

Signed-off-by: Jan Kundrát <jkt@flaska.net>

M  +1    -1    CMakeLists.txt
A  +-    --    src/icons/trojita.ico
A  +1    -0    src/trojita_ico_win32.rc

http://commits.kde.org/trojita/c008b4d795886cb34667cea7c4947c15a3cd8e96