Summary: | mouse pointer with red-eye reduction | ||
---|---|---|---|
Product: | [Applications] gwenview | Reporter: | jean.ribiere |
Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | bugseforuns, myriam, nate |
Priority: | NOR | Keywords: | usability |
Version: | 4.10.4 | ||
Target Milestone: | --- | ||
Platform: | Slackware | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/gwenview/e97eda1df871cebc87834822a08c5f34fc80938b | Version Fixed In: | 18.08.0 |
Description
jean.ribiere
2013-07-04 07:17:10 UTC
Confirmed. Might be an easy fix. Let's see if I can work up a patch. Clearly a bug, since the code *tries* to set an appropriate cursor: void RedEyeReductionTool::toolActivated() { imageView()->setCursor(Qt::CrossCursor); } Looks like whatever part sets the hand cursor is always overriding this. It looks like this affects other tools, too. Git commit e97eda1df871cebc87834822a08c5f34fc80938b by Henrik Fehlauer. Committed on 26/07/2018 at 18:36. Pushed by rkflx into branch 'Applications/18.08'. Fix crosshair cursor not showing in red eye reduction tool Summary: `RedEyeReductionTool::toolActivated` sets `Qt::CrossCursor` to allow for more precise positioning where to apply the red eye reduction. Due to `RasterImageView::setCurrentTool` calling `updateCursor` afterwards, that change is immediately overridden again, though. By moving around the latter, the issue can be fixed. FIXED-IN: 18.08.0 Test Plan: In {nav View} mode, activate the {nav Red Eye Reduction} tool. A crosshair cursor should show, and hide again upon closing the tool. Reviewers: #gwenview, ngraham Reviewed By: #gwenview, ngraham Subscribers: muhlenpfordt, ngraham Differential Revision: https://phabricator.kde.org/D14386 M +5 -1 lib/documentview/rasterimageview.cpp https://commits.kde.org/gwenview/e97eda1df871cebc87834822a08c5f34fc80938b |