| Summary: | Dolphin window title gets set to ugly strings ("Baloosearch -/", ) when displaying a Place that comes from a KIOSlave | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Julián Unrrein <junrrein> |
| Component: | search | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | aspotashev, bugseforuns, ht990332, kde, nate, simonandric5 |
| Priority: | NOR | Keywords: | usability |
| Version: | 4.12.4 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/702429ac8e64a5aff4e110a56f526b96ecb795fd | Version Fixed In: | |
| Attachments: | Window title while searching | ||
|
Description
Julián Unrrein
2013-06-24 19:32:56 UTC
Created attachment 80760 [details]
Window title while searching
*** Bug 333195 has been marked as a duplicate of this bug. *** Thanks for the suggestion. Note that this also applies to tab titles, and also to the 'baloosearch' kioslave. Replacing the tab/window titles manually based on the protocol is not pretty code-wise, but I see that there is no great value in showing the names of the different search protocols, which are implementation details, to the user. yes, this should probably be replaced with the actual search term. *** Bug 328859 has been marked as a duplicate of this bug. *** Looks like we already fixed this for some use cases (Trash, home) in https://cgit.kde.org/dolphin.git/commit/?id=652f57d28152491c42ad740d2bacd12a12d3d3d7 Not for the "baloosearch -/" one, though. Another data point: if you add a Places item with the URL baloosearch:/ and some label, as of the patch I mentioned, it now correctly displays the label in the window title instead of "baloosearch - /". So this is still wrong in only two situations: 1. Places with the "search:/" URL display "baloosearch - /" in the window title 2. Using the Find feature replaces the window title with "baloosearch - /" Git commit 702429ac8e64a5aff4e110a56f526b96ecb795fd by Nathaniel Graham, on behalf of Julian Schraner. Committed on 03/12/2017 at 15:00. Pushed by ngraham into branch 'master'. Change window title when searching Summary: When you search for a file (e.g. "hello world") the window title of Dolphin will now change to "Search for [input]" instead of "baloosearch - /". Test Plan: - Disables it iself after search bar is hidden - Works with multiple word searches Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, ngraham, elvisangelaccio Subscribers: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin Tags: #dolphin Differential Revision: https://phabricator.kde.org/D8273 M +10 -0 src/dolphinmainwindow.cpp M +5 -0 src/dolphinviewcontainer.cpp M +2 -0 src/dolphinviewcontainer.h https://commits.kde.org/dolphin/702429ac8e64a5aff4e110a56f526b96ecb795fd |