| Summary: | The $SubmitPending flag is not cleared upon succesful submit | ||
|---|---|---|---|
| Product: | [Unmaintained] trojita | Reporter: | Jan Kundrát <jkt> |
| Component: | Message Composer | Assignee: | Trojita default assignee <trojita-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | git | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Jan Kundrát
2013-06-19 13:23:21 UTC
Git commit b34c62841241092fb188f47b8ea111999cf1ec0c by Jan Kundrát. Committed on 23/10/2013 at 01:24. Pushed by jkt into branch 'master'. Do not set the $SubmitPending flag during the initial submission attempt The $SubmitPending IMAP keywords on its own is meant to indicate that "this message needs to be sent out" [1]; MUAs are supposed to use both $Submitted and $SubmitPending when the message is actively submitted, and just $Submitted when the message was sent. This is a serious bug -- a reasonable client could very well look at the Sent mailbox and tell users "Hey, it looks like there's a ton of messages to be sent in there which were never actually sent. Do you want me to send them now?". We should have never set this flag without proper support for $Submitted in place, but this misfeature has been around since mid-2012 :(. Sorry to all who are affected by this, I haven't realized this implication. [1] http://tools.ietf.org/html/rfc5550#section-5.10 REVIEW: 113396 M +2 -2 src/Composer/Submission.cpp M +5 -5 tests/Composer/test_Composer_Submission.cpp http://commits.kde.org/trojita/b34c62841241092fb188f47b8ea111999cf1ec0c |