Bug 321381 - The $SubmitPending flag is not cleared upon succesful submit
Summary: The $SubmitPending flag is not cleared upon succesful submit
Status: RESOLVED FIXED
Alias: None
Product: trojita
Classification: Unmaintained
Component: Message Composer (other bugs)
Version First Reported In: git
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Trojita default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-19 13:23 UTC by Jan Kundrát
Modified: 2014-03-16 17:41 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kundrát 2013-06-19 13:23:21 UTC
The code which will do this is commented out in Submission.cpp; there's a couple of issues with the logic in there.

Continuing from https://projects.flaska.net/issues/554.
Comment 1 Jan Kundrát 2013-10-24 15:13:30 UTC
Git commit b34c62841241092fb188f47b8ea111999cf1ec0c by Jan Kundrát.
Committed on 23/10/2013 at 01:24.
Pushed by jkt into branch 'master'.

Do not set the $SubmitPending flag during the initial submission attempt

The $SubmitPending IMAP keywords  on its own is meant to indicate that "this
message needs to be sent out" [1]; MUAs are supposed to use both $Submitted and
$SubmitPending when the message is actively submitted, and just $Submitted when
the message was sent.

This is a serious bug -- a reasonable client could very well look at the Sent
mailbox and tell users "Hey, it looks like there's a ton of messages to be sent
in there which were never actually sent. Do you want me to send them now?". We
should have never set this flag without proper support for $Submitted in place,
but this misfeature has been around since mid-2012 :(.

Sorry to all who are affected by this, I haven't realized this implication.

[1] http://tools.ietf.org/html/rfc5550#section-5.10

REVIEW: 113396

M  +2    -2    src/Composer/Submission.cpp
M  +5    -5    tests/Composer/test_Composer_Submission.cpp

http://commits.kde.org/trojita/b34c62841241092fb188f47b8ea111999cf1ec0c