Summary: | Slide effect sometimes leaves glitch on the screen | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Ralf Jung <post> |
Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hrvoje.senjan, metamorfozis, paulo.miguel.dias, robby.engelmann |
Priority: | NOR | Flags: | thomas.luebking:
ReviewRequest+
|
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/126323/ | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=346789 https://bugs.kde.org/show_bug.cgi?id=344359 https://bugs.kde.org/show_bug.cgi?id=356515 https://bugs.kde.org/show_bug.cgi?id=318322 |
||
Latest Commit: | http://commits.kde.org/kwin/87795eef2a71d85680f797fe75404ca1a9a63a10 | Version Fixed In: | 5.6 |
Attachments: | A screenshot, with the glitch highlighted |
Description
Ralf Jung
2013-06-08 12:29:53 UTC
Created attachment 80392 [details]
A screenshot, with the glitch highlighted
(and my awsome drawing skills revealed...)
Could also be due to the moment when plasma withdraws the shadow. a) plasma-desktop from git master? b) blur related? c) for a cross-test: https://sourceforge.net/projects/bekwinfx/ - the animation component (generic animations) has a SP feature on top of AnimationEffect (In reply to comment #2) > a) plasma-desktop from git master? Yes, it's all master, with kdelibs, kde-runtime and kde-network updated today or yesterday. > b) blur related? It happens both with blur enabled and disabled. > c) for a cross-test: https://sourceforge.net/projects/bekwinfx/ - the > animation component (generic animations) has a SP feature on top of > AnimationEffect What's SP? Not sure what you want me to test here. (In reply to comment #3) > Yes, it's all master, with kdelibs, kde-runtime and kde-network updated > today or yesterday. This must be kde-workspace of course, sorry. (In reply to comment #3) > > c) for a cross-test: https://sourceforge.net/projects/bekwinfx/ - the > > animation component (generic animations) has a SP feature on top of > > AnimationEffect > What's SP? Not sure what you want me to test here. "Sliding Popups" - the glitchy effect. In the generic animation plugin just check "animate plasma popups" With BE::Animated, this glitch does not seem to happen - or maybe it's just way less likely, but I didn't see it when I tried around 10 to twenty times, while it happens almost always with the "original" effect. However, the menu disappears for about one or two frames before appearing again to slide down animated. I just reproduced this issue on my other machine, with current kde-master and the proprietary NVidia drivers (version 319.17). So its not HW/vendor-dependent. *** Bug 345110 has been marked as a duplicate of this bug. *** *** Bug 343455 has been marked as a duplicate of this bug. *** *** Bug 355333 has been marked as a duplicate of this bug. *** Can somebody check this: diff --git a/effects/slidingpopups/slidingpopups.cpp b/effects/slidingpopups/slidingpopups.cpp index 63fd67f..3c22214 100644 --- a/effects/slidingpopups/slidingpopups.cpp +++ b/effects/slidingpopups/slidingpopups.cpp @@ -320,7 +320,7 @@ void SlidingPopupsEffect::slotWindowDeleted(EffectWindow* w) delete mAppearingWindows.take(w); delete mDisappearingWindows.take(w); mWindowsData.remove(w); - effects->addRepaint(w->geometry()); + effects->addRepaint(w->expandedGeometry()); } void SlidingPopupsEffect::slotPropertyNotify(EffectWindow* w, long a) -- (it would be better ported to an AnimationEffect ....) Git commit 57c9aa9fc03d8af1afd63b43c136894cdef621d2 by Thomas Lübking. Committed on 14/01/2016 at 22:37. Pushed by luebking into branch 'master'. update expanded geometry when slide is done In addition it's required to keep the expandedGeometry alive until the effects handled the deletion Related: bug 318322, bug 344359 REVIEW: 126323 FIXED-IN: 5.6 M +1 -1 effects/slidingpopups/slidingpopups.cpp http://commits.kde.org/kwin/57c9aa9fc03d8af1afd63b43c136894cdef621d2 Git commit 87795eef2a71d85680f797fe75404ca1a9a63a10 by Thomas Lübking. Committed on 15/01/2016 at 00:37. Pushed by luebking into branch 'master'. Actually keep the expandedGeometry alive ... until the effects handled the deletion Related: bug 318322, bug 344359 REVIEW: 126323 FIXED-IN: 5.6 M +1 -1 composite.cpp http://commits.kde.org/kwin/87795eef2a71d85680f797fe75404ca1a9a63a10 |