| Summary: | MusicBrainz 3 include directory is not used | ||
|---|---|---|---|
| Product: | kscd | Reporter: | Vadim Zhukov <persgray> |
| Component: | general | Assignee: | Multimedia Developers <kde-multimedia> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | rdieter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | OpenBSD | ||
| OS: | OpenBSD | ||
| Latest Commit: | http://commits.kde.org/kscd/584e337f555b207e9d4027631fb9a993ca8e26d3 | Version Fixed In: | |
| Attachments: | Patch to fix issue | ||
Created attachment 80340 [details]
Patch to fix issue
Good start, thanks. I took your initial fix here, added some pkgconfig hints/love, and ended up with: https://git.reviewboard.kde.org/r/110852/ Nice! I don't have commit rights in KDE, but diff looks definitely good! I'd just omit the comments you added, they are obvious and duplicate CMake recommendations anyway. Git commit 5f78eaa674aa74c61555269ce664e375072f825c by Rex Dieter. Committed on 06/06/2013 at 17:43. Pushed by rdieter into branch 'KDE/4.13'. Improve MusicBrainz3 buildsys support - include directory is not used - add pkgconfig hints REVIEW: 110852 M +2 -1 CMakeLists.txt M +16 -3 cmake/FindMusicBrainz3.cmake http://commits.kde.org/kscd/5f78eaa674aa74c61555269ce664e375072f825c Git commit 584e337f555b207e9d4027631fb9a993ca8e26d3 by Rex Dieter. Committed on 06/06/2013 at 17:43. Pushed by rdieter into branch 'master'. Improve MusicBrainz3 buildsys support - include directory is not used - add pkgconfig hints REVIEW: 110852 M +2 -1 CMakeLists.txt M +16 -3 cmake/FindMusicBrainz3.cmake http://commits.kde.org/kscd/584e337f555b207e9d4027631fb9a993ca8e26d3 |
The build breaks on OpenBSD beacuse KSCd's CMakeLists.txt is missing ${MUSICBRAINZ3_INCLUDE_DIR}. Patch to fix this issue is attached. Reproducible: Always