Bug 320808 - MusicBrainz 3 include directory is not used
Summary: MusicBrainz 3 include directory is not used
Status: RESOLVED FIXED
Alias: None
Product: kscd
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: OpenBSD OpenBSD
: NOR normal
Target Milestone: ---
Assignee: Multimedia Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-06 09:16 UTC by Vadim Zhukov
Modified: 2014-05-11 12:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to fix issue (418 bytes, patch)
2013-06-06 09:16 UTC, Vadim Zhukov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim Zhukov 2013-06-06 09:16:13 UTC
The build breaks on OpenBSD beacuse KSCd's CMakeLists.txt is missing ${MUSICBRAINZ3_INCLUDE_DIR}. Patch to fix this issue is attached.

Reproducible: Always
Comment 1 Vadim Zhukov 2013-06-06 09:16:40 UTC
Created attachment 80340 [details]
Patch to fix issue
Comment 2 Rex Dieter 2013-06-06 17:49:44 UTC
Good start, thanks.

I took your initial fix here, added some pkgconfig hints/love, and ended up with:
https://git.reviewboard.kde.org/r/110852/
Comment 3 Vadim Zhukov 2013-06-06 21:38:02 UTC
Nice! I don't have commit rights in KDE, but diff looks definitely good! I'd just omit the comments you added, they are obvious and duplicate CMake recommendations anyway.
Comment 4 Rex Dieter 2014-05-11 12:50:26 UTC
Git commit 5f78eaa674aa74c61555269ce664e375072f825c by Rex Dieter.
Committed on 06/06/2013 at 17:43.
Pushed by rdieter into branch 'KDE/4.13'.

Improve MusicBrainz3 buildsys support

- include directory is not used
- add pkgconfig hints
REVIEW: 110852

M  +2    -1    CMakeLists.txt
M  +16   -3    cmake/FindMusicBrainz3.cmake

http://commits.kde.org/kscd/5f78eaa674aa74c61555269ce664e375072f825c
Comment 5 Rex Dieter 2014-05-11 12:50:44 UTC
Git commit 584e337f555b207e9d4027631fb9a993ca8e26d3 by Rex Dieter.
Committed on 06/06/2013 at 17:43.
Pushed by rdieter into branch 'master'.

Improve MusicBrainz3 buildsys support

- include directory is not used
- add pkgconfig hints
REVIEW: 110852

M  +2    -1    CMakeLists.txt
M  +16   -3    cmake/FindMusicBrainz3.cmake

http://commits.kde.org/kscd/584e337f555b207e9d4027631fb9a993ca8e26d3