Summary: | Undo/Redo should be available for moving images from/to trash too | ||
---|---|---|---|
Product: | [Applications] gwenview | Reporter: | tesfabpel |
Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | accounts, benni, bugseforuns, john.kde, mcv, msdobrescu, myriam, nahoj, nate, null |
Priority: | HI | Keywords: | usability |
Version: | 4.10.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Unspecified | ||
Latest Commit: | Version Fixed In: |
Description
tesfabpel
2013-05-12 06:51:36 UTC
Seems like gwenview respects a setting in dolphin. It's in the dolphin preferences under General -> Confirmations named "(Ask for confirmation when) Moving files or folder to trash". Can you please check if this was deactivated in your dolphin config and if gwenview asks for confirmation when you activate it? Yes, that is the cause... Anyway I've found that if you delete the last photo in the folder, gwenview will keep showing it instead saying something like "There are no photos in this folder..." (In reply to comment #1) > Seems like gwenview respects a setting in dolphin. It's in the dolphin > preferences under General -> Confirmations named "(Ask for confirmation > when) Moving files or folder to trash". Can you please check if this was > deactivated in your dolphin config and if gwenview asks for confirmation > when you activate it? That would be nice. Maybe the image can go poof or something. There are multiple issues here: 1. Confirmation dialog when moving images to the trash: As noted, this follows the (desktop wide) setting from Dolphin. This could be moved to systemsettings for easier discovery (with a link from Dolphin and Gwenview), but nothing for Gwenview to do here at the moment, really (adding a link to Dolphin would be weird). 2. Close image view or move to next image after deletion: This has been fixed in b55420b2ac3d (Try to keep ContextManager in sync with viewed files in MainWindow) 3. Not being able to undo after moving images to the trash: This works in Dolphin, but not in Gwenview. Essentially, this needs to be plugged into the existing undo/redo infrastructure by taking inspiration from Dolphin's code. Let's make the bug about this. 4. Toast notification instead of menu entry for undo Yeah, a nice feature from mobile UIs. However, should be done in a coordinated effort across all apps by adding this to Frameworks, not only in Gwenview. Note we cannot just use Gwenview's undo bar, because this one is more about saving unsaved modifications and requires being able to jump back to the image in question. For now, adding it to the menu / as a shortcut should be good enough. I came here by looking for a bug that is similar to this one, so I add it here. 1. Gwenview does not always go to the next image when the currently viewed one is moved to another path (with Gwenview). Sometimes goes, sometimes not. When it does not, moving to the next or previous image in Gwenview goes through the existing image, like it is there (possibly some handle remains busy?). Also, in that case, going to the browse view displays the previous image to the moved one twice, in place of the moved one too. 2.Undo must be available in Gwenview when Gwenview is used to move files wherever, to some other path or to trash, which is the same to me as other path. If I move a file from tens of thousands of images with it, and I need to undo that it's unhandy as I need to find it in a lot of files. Anyway, it is an operation, so undo must be available. *** Bug 351134 has been marked as a duplicate of this bug. *** I support this, especially undo move to trash. I often delete images from Gwenview, but I find it pretty tedious when I delete one by mistake and I have to go to and through the trash to restore it. It would be great to be able to just Ctrl+Z. |