| Summary: | Solarized color scheme is horrible | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Jonathan Wakely <zilla> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | broken.zhou, scarpino |
| Priority: | NOR | ||
| Version: | 2.10.2 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/konsole/e162743179475e439e78e5afcbfe254ec0f3ef3e | Version Fixed In: | 2.12 |
| Sentry Crash Report: | |||
| Attachments: |
Insane color scheme
Sane colour scheme The colorscheme after new commit. The colorscheme before new commit The original color scheme. A slighted modified version of original Solarized before the commit. effect of new version. Effect of vim, at a slighed modified colorscheme. New solarized scheme for this kde colorscheme. Fix the problem such that Background Intense != Color 1 Intense. |
||
|
Description
Jonathan Wakely
2013-04-29 11:46:56 UTC
Created attachment 79542 [details]
Insane color scheme
This shows the awful combination of using Konsole's Solarized scheme with Vim's Solarized scheme, which should be a joyous and harmonious combination.
Created attachment 79543 [details] Sane colour scheme This shows the expected behaviour, using the "Solarized Dark" scheme from https://github.com/phiggins/konsole-colors-solarized with Vim's Solarized scheme. *** Bug 323013 has been marked as a duplicate of this bug. *** Git commit e162743179475e439e78e5afcbfe254ec0f3ef3e by Kurt Hindenburg. Committed on 11/08/2013 at 21:23. Pushed by hindenburg into branch 'master'. Correct Solarized Dark colors and add a Light version I don't recall why the original Solarized had a few colors way off. These versions appear to match other solarized apps. https://github.com/phiggins/konsole-colors-solarized FIXED-IN: 2.12 M +17 -17 data/color-schemes/Solarized.colorscheme C +18 -18 data/color-schemes/SolarizedLight.colorscheme [from: data/color-schemes/Solarized.colorscheme - 075% similarity] http://commits.kde.org/konsole/e162743179475e439e78e5afcbfe254ec0f3ef3e I even prefer the original one. This looks horrible in almost all terminal application if it isn't optimized for this particular color such as ls, eix because many color are so similar. What should be changed mainly is colorscheme of your vim. Created attachment 81649 [details]
The colorscheme after new commit.
Created attachment 81650 [details]
The colorscheme before new commit
Created attachment 81651 [details]
The original color scheme.
Created attachment 81652 [details]
A slighted modified version of original Solarized before the commit.
This should fix all the problem.
Created attachment 81653 [details]
effect of new version.
Created attachment 81654 [details]
Effect of vim, at a slighed modified colorscheme.
Created attachment 81655 [details]
New solarized scheme for this kde colorscheme.
Conclusion: This version has better compatible with other terminal application while still usable in vim.
Created attachment 81656 [details]
Fix the problem such that Background Intense != Color 1 Intense.
Sorry for another post. But this should fix some problem for people like it.
(In reply to comment #6) > What should be changed mainly is colorscheme of your vim. I'm using the official Solarized scheme for VIm, written by the original designer of the Solarized pallete, so I don't think that's where the problem was. (In reply to comment #15) > (In reply to comment #6) > > What should be changed mainly is colorscheme of your vim. > > I'm using the official Solarized scheme for VIm, written by the original > designer of the Solarized pallete, so I don't think that's where the problem > was. Do your `ls --color=auto` still has beautiful color? I confirm Yichao's issues. His Solarized version fixed my colors. The colorscheme in comment 14 is unusable with the official solarized scheme for Vim, it has grey text on a grey background. If you want to create a different colour scheme don't pretend it's Solarized and expect me to install a new vim scheme to go with it. Give your konsole and vim scheme a different name, and leave the Solarized scheme for Konsole alone. (The correct way to solve the problem with the output of 'ls' is to set different LS_COLORS that are compatible with solarized, not to bastardize the solarized scheme!) Can you provide a LS_COLORS that is compatible with solarized? BTW, I'm also a vim user and I fixed the orange (with the previous color theme) by calling 'highlight clear' in ~/.vimrc. Well, after using for some time I found my version still has a little problems in some terminal programs, such as kernel's menuconfig and htop. These problems are not insolvable: you will need some low contrast colours in order to make the the cursorline to work, while they cause problems in some other terminal programs. To make this problem worse, you cannot approximate these colours using xterm 256 colour space. I just want to say that solarized is really not a terminal-friendly colour scheme... (In reply to comment #18) > (The correct way to solve the problem with the output of 'ls' is to set > different LS_COLORS that are compatible with solarized, not to bastardize > the solarized scheme!) Could you give a method to make solarized compatible with htop? Patch its source code? (In reply to comment #20) > BTW, I'm also a vim user and I fixed the orange (with the previous color > theme) by calling 'highlight clear' in ~/.vimrc. That works, yes, thanks. I still say the colour scheme in comment 14 is not Solarized. It might be a great colour scheme, but it's not Solarized, so should not replace Konsole's Solarized scheme. I fixed ls by using dircolors from https://github.com/seebi/dircolors-solarized |