| Summary: | implement indirect painting mode for masks | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | vanyossi <ghevan> |
| Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, finticemo, halla, unusualcows |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/4b36c257a28d482c93dae8c8c5f229dccbaa4acb | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
layer mask with experimental brush painting over it.
[ ^ screenshot of the bug ] |
||
|
Description
vanyossi
2013-04-25 22:18:07 UTC
Created attachment 79451 [details]
layer mask with experimental brush painting over it.
I attach a test file with a mask and some brush strokes on the mask.
I am not too surprised. I guess the experiment brush cannot handle the fake gray+a thing for masks that we got recently. It's not the graya thing. The experiment brush works only on the nodes having IndirectPaintingSupport, which is not the case of masks currently. We have two options: either to implement IndirectPaintingSupport for masks or fix the Exp. Brush. I guess, the former option is better, because I heard painters asking for Wash Mode for painting masks, because the BuildUp one seems unnatural for them. Ah, okay. And yes, I agree -- having indirect painting mode for masks is pretty important. Created attachment 86390 [details]
[ ^ screenshot of the bug ]
I was about to report the same ( for 2.9pre-alpha), nice to see it already reported and confirmed.
Git commit 4b36c257a28d482c93dae8c8c5f229dccbaa4acb by Boudewijn Rempt. Committed on 29/01/2015 at 12:53. Pushed by rempt into branch 'calligra/2.9'. This also fixes bug 318882, artefacts when using the shape brush with the multihand tool. M +3 -3 krita/image/kis_indirect_painting_support.cpp M +3 -3 krita/image/kis_indirect_painting_support.h M +1 -0 krita/image/kis_mask.cc M +2 -1 krita/image/kis_mask.h M +0 -1 krita/plugins/paintops/experiment/kis_experiment_paintop.cpp http://commits.kde.org/calligra/4b36c257a28d482c93dae8c8c5f229dccbaa4acb Git commit 4b36c257a28d482c93dae8c8c5f229dccbaa4acb by Boudewijn Rempt. Committed on 29/01/2015 at 12:53. Pushed by rempt into branch 'calligra/2.9'. This also fixes bug 318882, artefacts when using the shape brush with the multihand tool. M +3 -3 krita/image/kis_indirect_painting_support.cpp M +3 -3 krita/image/kis_indirect_painting_support.h M +1 -0 krita/image/kis_mask.cc M +2 -1 krita/image/kis_mask.h M +0 -1 krita/plugins/paintops/experiment/kis_experiment_paintop.cpp http://commits.kde.org/calligra/4b36c257a28d482c93dae8c8c5f229dccbaa4acb Okay, it's _not_ indirect painting support -- and it's the same issue as 318488. *** Bug 318488 has been marked as a duplicate of this bug. *** Git commit be51bd9b206a58250dbd3d11cb9ca4908498b7f4 by Boudewijn Rempt. Committed on 04/02/2015 at 20:14. Pushed by rempt into branch 'calligra/2.9'. Break mirrored/mask use of the shape brush again Related: bug 318488 Even though masks now support indirect painting, this isn't enough to solve these two bugs. However, using another composite op than composite copy breaks the general usecase of the brush. M +1 -0 krita/plugins/paintops/experiment/kis_experiment_paintop.cpp http://commits.kde.org/calligra/be51bd9b206a58250dbd3d11cb9ca4908498b7f4 Git commit 9e7bae94cdd5dd3ac440f00f45254cc6e3be5881 by Boudewijn Rempt. Committed on 04/02/2015 at 20:14. Pushed by rempt into branch 'master'. Break mirrored/mask use of the shape brush again Related: bug 318488 Even though masks now support indirect painting, this isn't enough to solve these two bugs. However, using another composite op than composite copy breaks the general usecase of the brush. M +1 -0 krita/plugins/paintops/experiment/kis_experiment_paintop.cpp http://commits.kde.org/calligra/9e7bae94cdd5dd3ac440f00f45254cc6e3be5881 *** Bug 361771 has been marked as a duplicate of this bug. *** |