Bug 318407

Summary:	Shift key status not tracked correctly
Product:	[Applications] kcalc	Reporter:	Christoph Feck <cfeck>
Component:	general	Assignee:	Evan Teran <evan.teran>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Christoph Feck 2013-04-15 20:26:19 UTC

In master branch, a new way to toggle the "Shift" button has been added by simplying pressing the Shift key. Due to use of toggle() instead of explicit up/down handling, its status is not tracked correctly.

To reproduce (text in quotations marks are buttons, not keys):
- start kcalc
- click "6" button
- hold down Shift key and keep it pressed
- click "e^x" button
- release Shift key

Actual result:
- the "Shift" button is still active

Expected result:
- releasing the Shift key should also release the "Shift" button

Comment 1 Christoph Feck 2013-04-15 20:29:48 UTC

Additionally, as can be read on bug 283521, users might need to use the Shift key to enter numbers, so I do not think it is a wise choice to use that key for other purposes.

Comment 2 Evan Teran 2013-04-16 01:15:22 UTC

I am compelled to agree. That's why I didn't backport the Shift stuff to 4.10, cause I wasn't sure if it was a wise decision.

After seeing your conclusions, I will probably remove this feature. I'll close this bug once that is done.

Comment 3 Evan Teran 2013-04-16 16:18:10 UTC

The patch has been rolled back, the negative side effects unfortunately outweigh the gain of being able to press Shift.

I can't say that I love "Ctrl+2" being the shortcut currently, perhaps we can figure out some better shortcut in the future. But for now, it is as it was before this patch.