| Summary: | Unused libs linked in Telepathy Logger Qt | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | David Edmundson <kde> |
| Component: | telepathy-logger-qt | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dvratil |
| Priority: | NOR | ||
| Version: | git-latest | ||
| Target Milestone: | Future | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/telepathy-logger-qt/5142bd78d8a0f208e6d57be212380459a739f13b | Version Fixed In: | |
| Sentry Crash Report: | |||
Builds fine here. ldd reports them as unused as well, so I think it's fine:
$ ldd -u -r libtelepathy-logger-qt4.so
Unused direct dependencies:
/lib64/libdbus-1.so.3
/lib64/libxml2.so.2
/lib64/libdbus-glib-1.so.2
/lib64/libQtNetwork.so.4
/lib64/libQtXml.so.4
/lib64/libm.so.6
(QtXml and QtNetwork and dragged in probably by TelepathyQt4, so we can't get rid o these)
For me, ship it.
Git commit 5142bd78d8a0f208e6d57be212380459a739f13b by Martin Klapetek. Committed on 11/04/2013 at 17:19. Pushed by mklapetek into branch 'master'. Don't link against unneeded libs Reviewed-by: Dan Vratil M +0 -3 TelepathyLoggerQt4/CMakeLists.txt http://commits.kde.org/telepathy-logger-qt/5142bd78d8a0f208e6d57be212380459a739f13b |
Kubuntu are applying this patch and want to upstream it --- a/TelepathyLoggerQt4/CMakeLists.txt +++ b/TelepathyLoggerQt4/CMakeLists.txt @@ -177,9 +177,6 @@ ${GOBJECT_LIBRARIES} -lgio-2.0 ${QT_QTDBUS_LIBRARY} - ${DBUS_LIBRARIES} - ${LIBXML2_LIBRARIES} - ${DBUS_GLIB_LIBRARIES} ${TELEPATHY_GLIB_LIBRARIES} ${TELEPATHY_LOGGER_LIBRARIES} ${TELEPATHY_QT4_LIBRARIES} Dan can you check this makes sense. Talk to Quintasan and Rohan.