Bug 316318

Summary: fix warnings
Product: [Unmaintained] telepathy Reporter: Alin M Elena <alinm.elena>
Component: call-uiAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED NOT A BUG    
Severity: wishlist CC: mklapetek
Priority: NOR    
Version: git-latest   
Target Milestone: Future   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Bug Depends on:    
Bug Blocks: 316315    

Description Alin M Elena 2013-03-07 15:31:19 UTC
In file included from /usr/include/QtGStreamer/QGlib/Connect:1:0,
                 from /home/alin/lavello/ktp-call-ui/libktpcall/private/sink-manager.cpp:26:
/usr/include/QtGStreamer/QGlib/connect.h: In instantiation of ‘typename boost::enable_if<boost::is_integral<T>, unsigned int>::type QGlib::Private::hashMfp(const T&) [with T = int; typename boost::enable_if<boost::is_integral<T>, unsigned int>::type = unsigned int]’:
/usr/include/QtGStreamer/QGlib/connect.h:303:102:   required from ‘bool QGlib::disconnect(void*, const char*, void*, T) [with T = int]’
/home/alin/lavello/ktp-call-ui/libktpcall/private/sink-manager.cpp:59:45:   required from here
/usr/include/QtGStreamer/QGlib/connect.h:284:1: error: unused parameter ‘mfp’ [-Werror=unused-parameter]
cc1plus: all warnings being treated as errors
make[2]: *** [libktpcall/CMakeFiles/ktpcall.dir/private/sink-manager.o] Error 1
make[2]: Leaving directory `/home/alin/lavello/ktp-call-ui/build'
make[1]: *** [libktpcall/CMakeFiles/ktpcall.dir/all] Error 2
make[1]: Leaving directory `/home/alin/lavello/ktp-call-ui/build'
make: *** [all] Error 2


Reproducible: Always
Comment 1 Martin Klapetek 2013-11-15 09:38:24 UTC
This is a warning not coming from KTp but rather QGlib itself.

The code in QGlib is:

template <typename T>
inline typename boost::enable_if< boost::is_integral<T>, uint >::type
hashMfp(const T & mfp)
{
    Q_ASSERT(mfp == 0);
    return 0;
}

so the mfp variable is indeed unused, though only when build in release mode. We can't change code in QGlib, should be reported upstream.