Bug 316315

Summary: make it compile with -Werror -std=c++11
Product: [Unmaintained] telepathy Reporter: Alin M Elena <alinm.elena>
Component: generalAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED INTENTIONAL    
Severity: wishlist CC: mklapetek
Priority: NOR    
Version: git-latest   
Target Milestone: Future   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Bug Depends on: 316318, 316320    
Bug Blocks:    

Description Alin M Elena 2013-03-07 15:24:34 UTC
make all ktp components compile with 
-Werror -std=c++11

Reproducible: Always
Comment 1 Martin Klapetek 2013-11-15 09:29:10 UTC
Agreed on the -Werror. Not really agreeing with enabling c++11 just yet. We'll do whatever kde-workspace does now.
Comment 2 Martin Klapetek 2013-11-15 09:57:31 UTC
Git commit dcd35958416c14624213fea0523d417c5afd3b7c by Martin Klapetek.
Committed on 15/11/2013 at 09:57.
Pushed by mklapetek into branch 'master'.

Treat warnings as errors

M  +2    -0    CMakeLists.txt

http://commits.kde.org/telepathy-common-internals/dcd35958416c14624213fea0523d417c5afd3b7c
Comment 3 Martin Klapetek 2013-12-11 23:21:33 UTC
I just got told by many people that including -Werror is evil and should never ever be done in public repos as the warnings may come from any headers we're using, which is currently the case of ktp-common-internals failing on QtGstreamer.

Reverting the change then and closing as WONTFIX.