Bug 316172

Summary: Incoming highlighted messages have an extra line
Product: [Unmaintained] telepathy Reporter: Daniele E. Domenichelli <ddomenichelli>
Component: text-ui-message-filtersAssignee: Telepathy Bugs <kde-telepathy-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: kde
Priority: NOR    
Version First Reported In: git-latest   
Target Milestone: 0.6.0   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/telepathy-text-ui/cdb416c04da71881ee52d06a9a5147ebf2b64b3d Version Fixed In:
Sentry Crash Report:

Description Daniele E. Domenichelli 2013-03-05 13:48:04 UTC 
The extra <div> seems to be adding an extra line, see http://wstaw.org/m/2013/03/05/snapshot122.png
Comment 1 David Edmundson 2013-03-05 13:58:27 UTC 
This is either caused by the sendMessages filter OR by the patch to make the text-ui send message shortcut configurable. 

If someone could find out which patch breaks it, that would really help.
Comment 2 David Edmundson 2013-03-06 13:00:10 UTC 
Git commit cdb416c04da71881ee52d06a9a5147ebf2b64b3d by David Edmundson.
Committed on 06/03/2013 at 05:06.
Pushed by davidedmundson into branch 'master'.

Use theme to highlight messages

Rather than hardcoding red, pass a special messageClass to the theme which highlights it for us
Looks better, and is theme dependant.

REVIEW: 109309

M  +0    -6    filters/highlight/highlight-filter.cpp
M  +4    -0    lib/chat-widget.cpp

http://commits.kde.org/telepathy-text-ui/cdb416c04da71881ee52d06a9a5147ebf2b64b3d