| Summary: | extracti18n.pl and i18ndata file suggestions | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | margueritesu <i> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | animtim, halla, lueck, sven.langkamp |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/287efe42475bb955d05e343ca8f867ad84d08da4 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
margueritesu
2013-02-22 11:32:40 UTC
Hi Marguerite, Thanks for your input. We can't do much about the size of the git repo, I'm afraid, but your other suggestions are sound. Well this is a big problem with lots of implications: To make it simple we recently decided on the ressource/presets guidelines to have filenames = description. So one can easily find the corresponding file matching the description string (if any). There are still a few files that have different filename/description, these should be cleaned up to follow this guideline. In this regard, it conflicts a bit with the idea of translatable string, as if those get translated they won't match the file names anymore... We also decided to avoid too long file names. On the pattern files, most of them just show file names directly (all the png files, and most of the pat files) On the brushes files, most of them have already been edited to have description string = filename. A few still need this, and a few may need a better descriptive filename too.. Problem is if we rename some of those files, it also breaks all presets using it, for default pack (those I can edit) but also for user presets.. That's why mass ressource renaming should be avoided (which explains why some still have not optimal names..) Also I wonder if having those strings translated may have a bad side effect: Do presets use filenames only or description to link brushes/patterns? Same question for tagging? Then about the term "canvas" used in some patterns, well I don't see a better word for this is exactly some canvas pattern, meant to fake material canvas one paints on in real life.. changing it to jeans or whatever would miss totally this meaning. The only change I see would be to change the strings to something like:
i18nc("./data/brushes/U_Circle_shape_4.gbr","U Circle shape 4");
i18nc("./data/brushes/U_Circle_shape_5.gbr","U Circle shape 5");
We can't change the filename themself as they might be referenced in some presets already.
Git commit 287efe42475bb955d05e343ca8f867ad84d08da4 by Sven Langkamp. Committed on 02/04/2014 at 17:25. Pushed by langkamp into branch 'master'. added file hint for resource translations M +7 -7 krita/extracti18n.pl http://commits.kde.org/calligra/287efe42475bb955d05e343ca8f867ad84d08da4 |