Bug 315552

Summary: Allow save annotations directly to original pdf file
Product: [Applications] okular Reporter: GSC <xgdgsc>
Component: generalAssignee: Okular developers <okular-devel>
Severity: wishlist CC: 4aa7f31e, aacid, amy, arthur, azrdev, b344806, codestruct, flying-sheep, h4xx0rz, haavard, j.gjorgji, jonathan.verner, m.weghorn, nate, Sasha.Medvedev, simonandric5, ssameer+bugs, stevenroose, zhx
Priority: NOR    
Version: 0.16.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:

Description GSC 2013-02-21 02:57:14 UTC
Wish it can save with menu or ctrl+s directly to original file without file dialog.

Reproducible: Always

Steps to Reproduce:
2.try to save it

Actual Results:  
 have to use save as/save a copy as to save. 

Expected Results:  
allow directly save to original file by ctrl+s/FIle->Save/Toolbar->Save
Comment 1 ssameer+bugs 2013-10-23 00:24:42 UTC
One use case where this would be very convenient is when the user is annotating a pdf document over a network (smb/cifs/nfs). KDE downloads the document to a temp directory and a program (Okular) opens it. If it is changed, KDE automatically uploads the changed document back to the network folder. If the annotations are saved to a different pdf file, KDE will not upload it back automatically and the user has to do it manually. 

Automatically saving changes to annotations (without the user having to press Control+S) directly to the original pdf file would be very convenient too.
Comment 2 Christoph Feck 2014-01-15 23:25:01 UTC
*** Bug 326153 has been marked as a duplicate of this bug. ***
Comment 3 Fabio D'Urso 2014-02-04 10:31:06 UTC
*** Bug 330740 has been marked as a duplicate of this bug. ***
Comment 4 Amy de Buitléir 2014-07-09 10:12:58 UTC
*** This bug has been confirmed by popular vote. ***
Comment 5 Amy de Buitléir 2014-07-09 10:27:25 UTC
Alternatively, https://bugs.kde.org/show_bug.cgi?id=228114 or https://bugs.kde.org/show_bug.cgi?id=305412 would satisfy my use case (making and seeing annotations on the same document from multiple machines).
Comment 6 Jonathan Verner 2015-06-11 12:23:40 UTC
*** Bug 348642 has been marked as a duplicate of this bug. ***
Comment 7 Jonathan Verner 2015-06-11 12:33:54 UTC
It was pointed out to me by Luigi Toscano that there was some discussion of reworking the whole 'saving annotations' logic (see https://forum.kde.org/viewtopic.php?f=251&t=122750). Looking at the git repository it seems that Fabio D'Urso did some work on implementing the changes in the 'dont-use-docdata-for-annots-and-forms' branch but I don't know what the status of those changes is. 

Not knowing all of this and thinking that adding a 'Save' menu item should be a rather trivial change I went ahead and tried implementing it here:

Comment 8 Albert Astals Cid 2016-05-28 22:46:12 UTC
*** Bug 350991 has been marked as a duplicate of this bug. ***
Comment 9 CnZhx 2017-08-08 15:16:28 UTC
Should we mark this bug/feature solved as per the document here https://docs.kde.org/trunk5/en/kdegraphics/okular/annotations.html
Comment 10 Albert Astals Cid 2017-08-08 20:23:07 UTC
No, because we don't support Ctrl+S yet.
Comment 11 CnZhx 2017-08-08 20:33:23 UTC
Sorry for the mistake. But I can use Ctrl+s to save the document with annotation as a new pdf file or replace the original one on following environment:
openSUSE Tumbleweed: 20170628
KDE Plasma: 5.10.2
Qt: 5.9.0
KDE Frameworks: 5.34.0
Kernel: 4.11.7-1-default
Okular: Version 1.1.2
PDF Backend: Version 0.6.5
So I thought it's solved.
Comment 12 Gregor Mi 2017-08-08 20:45:22 UTC
@CnZhx: Normally, Ctrl+S is the "Save" action. So, the usage of Ctrl+S for "Save as..." (which is Ctrl+Shift+S by default) is a non-standard behavior that can confuse users. This will be fixed.
Comment 13 CnZhx 2017-08-08 20:56:44 UTC
Thank you, Gregor, for your clarification. It seems I am exactly one of the confused.
Comment 14 Nate Graham 2017-08-17 23:28:31 UTC
Albert, is this close enough that we could consider it a duplicate of https://bugs.kde.org/show_bug.cgi?id=315552?
Comment 15 Albert Astals Cid 2017-08-18 21:44:26 UTC
Duplicating a bug against itself is kind of cheating ;)
Comment 16 Nate Graham 2017-08-18 21:45:57 UTC
Haha whoops! Definitely didn't mean to do that. And now I can't remember which bug I was trying to dupe it against, shoot.
Comment 17 Christoph Feck 2017-08-30 16:40:04 UTC
Bug 151614?
Comment 18 Albert Astals Cid 2017-08-30 21:22:32 UTC
(In reply to Christoph Feck from comment #17)
> Bug 151614?

No, this bug is about "Ctrl+S" actually working like in a normal program. Which we don't have yet.
Comment 19 Christoph Feck 2017-10-19 13:26:54 UTC
*** Bug 385943 has been marked as a duplicate of this bug. ***
Comment 20 Christoph Feck 2017-10-19 13:28:01 UTC
Nate, maybe bug 301774?
Comment 21 Nate Graham 2017-10-19 14:59:13 UTC
*** Bug 301774 has been marked as a duplicate of this bug. ***
Comment 22 Nate Graham 2017-10-19 15:00:10 UTC
Yeah, looks like it. Even though that bugs is older, let's consolidate here since this bug is clearer and more technical, and doesn't have so much distracting argument in it.
Comment 23 Michael Weghorn 2017-11-21 15:31:02 UTC
As far as I understand, the feature requested in this bug is now implemented and this bug can therefore probably closed.
Comment 24 Nate Graham 2017-11-21 15:33:42 UTC
Indeed it is! Fixed in https://cgit.kde.org/okular.git/commit/?id=3957683d7651494a7bc48b26e6b113161e9a888c
Comment 25 Nate Graham 2017-11-21 23:28:45 UTC
Indeed it is! Fixed in https://cgit.kde.org/okular.git/commit/?id=3957683d7651494a7bc48b26e6b113161e9a888c