| Summary: | Allow save annotations directly to original pdf file | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | GSC <xgdgsc> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | 4aa7f31e, aacid, amy, arthur, azrdev, b344806, codestruct, flying-sheep, h4xx0rz, haavard, j.gjorgji, jonathan.verner, m.weghorn, nate, Sasha.Medvedev, simonandric5, ssameer+bugs, stevenroose, zhx |
| Priority: | NOR | ||
| Version: | 0.16.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | 3957683d7651494a7bc48b26e6b113161e9a888c | Version Fixed In: | |
|
Description
GSC
2013-02-21 02:57:14 UTC
One use case where this would be very convenient is when the user is annotating a pdf document over a network (smb/cifs/nfs). KDE downloads the document to a temp directory and a program (Okular) opens it. If it is changed, KDE automatically uploads the changed document back to the network folder. If the annotations are saved to a different pdf file, KDE will not upload it back automatically and the user has to do it manually. Automatically saving changes to annotations (without the user having to press Control+S) directly to the original pdf file would be very convenient too. *** Bug 326153 has been marked as a duplicate of this bug. *** *** Bug 330740 has been marked as a duplicate of this bug. *** *** This bug has been confirmed by popular vote. *** Alternatively, https://bugs.kde.org/show_bug.cgi?id=228114 or https://bugs.kde.org/show_bug.cgi?id=305412 would satisfy my use case (making and seeing annotations on the same document from multiple machines). *** Bug 348642 has been marked as a duplicate of this bug. *** It was pointed out to me by Luigi Toscano that there was some discussion of reworking the whole 'saving annotations' logic (see https://forum.kde.org/viewtopic.php?f=251&t=122750). Looking at the git repository it seems that Fabio D'Urso did some work on implementing the changes in the 'dont-use-docdata-for-annots-and-forms' branch but I don't know what the status of those changes is. Not knowing all of this and thinking that adding a 'Save' menu item should be a rather trivial change I went ahead and tried implementing it here: https://git.reviewboard.kde.org/r/124069/ *** Bug 350991 has been marked as a duplicate of this bug. *** Should we mark this bug/feature solved as per the document here https://docs.kde.org/trunk5/en/kdegraphics/okular/annotations.html No, because we don't support Ctrl+S yet. Sorry for the mistake. But I can use Ctrl+s to save the document with annotation as a new pdf file or replace the original one on following environment: ``` openSUSE Tumbleweed: 20170628 KDE Plasma: 5.10.2 Qt: 5.9.0 KDE Frameworks: 5.34.0 Kernel: 4.11.7-1-default Okular: Version 1.1.2 PDF Backend: Version 0.6.5 ``` So I thought it's solved. @CnZhx: Normally, Ctrl+S is the "Save" action. So, the usage of Ctrl+S for "Save as..." (which is Ctrl+Shift+S by default) is a non-standard behavior that can confuse users. This will be fixed. Thank you, Gregor, for your clarification. It seems I am exactly one of the confused. Albert, is this close enough that we could consider it a duplicate of https://bugs.kde.org/show_bug.cgi?id=315552? Duplicating a bug against itself is kind of cheating ;) Haha whoops! Definitely didn't mean to do that. And now I can't remember which bug I was trying to dupe it against, shoot. (In reply to Christoph Feck from comment #17) > Bug 151614? No, this bug is about "Ctrl+S" actually working like in a normal program. Which we don't have yet. *** Bug 385943 has been marked as a duplicate of this bug. *** Nate, maybe bug 301774? *** Bug 301774 has been marked as a duplicate of this bug. *** Yeah, looks like it. Even though that bugs is older, let's consolidate here since this bug is clearer and more technical, and doesn't have so much distracting argument in it. As far as I understand, the feature requested in this bug is now implemented and this bug can therefore probably closed. Indeed it is! Fixed in https://cgit.kde.org/okular.git/commit/?id=3957683d7651494a7bc48b26e6b113161e9a888c Indeed it is! Fixed in https://cgit.kde.org/okular.git/commit/?id=3957683d7651494a7bc48b26e6b113161e9a888c |