| Summary: | Timeline-Urls can not be set as homepage | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | m.wege |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | junior-jobs |
| Priority: | NOR | ||
| Version: | 2.1.97 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/26cf73dcac2754db05a142662869179f72a536fe | Version Fixed In: | 4.10 |
|
Description
m.wege
2013-01-12 20:33:18 UTC
Thanks for the bug report. The check that we perform for the new 'home URL' in StartupSettingsPage::applySettings() is if (url.isValid() && fileItem.isDir()) It seems that the 'timeline' KFileItem is not considered a directory. Maybe this could be fixed by adding an exception for 'timeline' URLs. Looks like a good 'junior job' for potential new contributors. Git commit 87a4eb9eaf69b8d0d4d873da75d240a410b05ed0 by Andrea Scarpino. Committed on 16/01/2013 at 23:05. Pushed by scarpino into branch 'master'. Allow Timeline-URLs as homepage REVIEW: 108428 M +1 -1 dolphin/src/settings/startup/startupsettingspage.cpp http://commits.kde.org/kde-baseapps/87a4eb9eaf69b8d0d4d873da75d240a410b05ed0 Git commit 26cf73dcac2754db05a142662869179f72a536fe by Andrea Scarpino. Committed on 16/01/2013 at 23:05. Pushed by scarpino into branch 'KDE/4.10'. Allow Timeline-URLs as homepage REVIEW: 108428 M +1 -1 dolphin/src/settings/startup/startupsettingspage.cpp http://commits.kde.org/kde-baseapps/26cf73dcac2754db05a142662869179f72a536fe |