Bug 312339

Summary: USABILITY: Make tab switching able to cycle tabs.
Product: [Frameworks and Libraries] telepathy Reporter: sombragris
Component: text-uiAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version: 0.5.2   
Target Milestone: Future   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/telepathy-text-ui/72a2a40b97a4879fdf8080a4d1d2de6c48f16978 Version Fixed In: 0.5.3

Description sombragris 2012-12-29 14:50:07 UTC 
In Text-UI, when one has multiple chats, one can switch back and forth between chats thanks to the Previous Tab and Next Tab shortcuts, which are configurable. They work fine and I'm grateful for them, because they're a real time saver.

Now what I'm asking is this:
* When one is at the *last* tab, pressing the "Next Tab" shortcut should cause text-ui to cycle, i.e., to show the *first* tab.

* When one is at the *first* tab, pressing the "Previous Tab" shortcut should cause text-ui to go to the *last* chat.

This would be really appreciated. Also, it would be consistent with the behavior of other tabbed applications in KDE. Thanks!

Reproducible: Always

Steps to Reproduce:
1. In Text-ui, go to the last conversation tab in a window with multiple tabs.
2. Press the Next-Tab shortcut
3. Nothing happens;
Actual Results:  
Nothing. And that's the problem.

Expected Results:  
It should cycle tabs.
Comment 1 David Edmundson 2012-12-30 16:32:10 UTC 
Git commit 72a2a40b97a4879fdf8080a4d1d2de6c48f16978 by David Edmundson.
Committed on 29/12/2012 at 16:38.
Pushed by davidedmundson into branch 'kde-telepathy-0.5'.

Cycle through tabs with next/prev tabs
FIXED-IN: 0.5.3
Reviewed-by: Martin Klapetek

M  +13   -1    app/chat-window.cpp

http://commits.kde.org/telepathy-text-ui/72a2a40b97a4879fdf8080a4d1d2de6c48f16978
Comment 2 sombragris 2012-12-30 20:08:31 UTC 
Thank you :)