| Summary: | cannot import photos from autodetected Canon PowerShot A1300 [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | kavol <kavol> |
| Component: | Import-Gphoto2 | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, maxantispam, nicofo, rdieter, sreedharpalayil, tpr |
| Priority: | NOR | ||
| Version: | 3.1.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/1f0dbbd3b3a6246e8c66b038a3f1e06af2f5ee11 | Version Fixed In: | 3.2.0 |
| Sentry Crash Report: | |||
| Attachments: |
fix for the regression
0001-find-devices-by-usb-vendor-and-product-id-also-if.patch |
||
|
Description
kavol
2012-12-09 09:17:56 UTC
Sound like a failure from GPhoto2 shared lib or KDE Solid API to detect camera model... Gilles Caulier *** Bug 311394 has been marked as a duplicate of this bug. *** User in question here is on fedora18 with gphoto-2.5, may be some side effect of porting to the newer api (see bug #303427) I'm trying to come up with some minimal test case to verify that or not (help welcome) Same problem for me (with a nikon coolpix) (see digikam output below) - Fedora 18 (KDE 4.9.5) as well - libgphoto2-2.5.0-7.fc18.i686 - digikam-2.9.0-3.fc18.i686 1) after the reading previous comment, I have tried to downgrade (*) libgphoto2 and use the version of Fedora 16 or 17 (libgphoto2-2.4.11-1.fc16.i686.rpm or libgphoto2-2.4.14-1.fc17.i686.rpm) -> same problem: the output of digikam (see below) is exactly the same. ( (*) downgrade using rpm --nodeps --force and linking libgphoto2.so.6 and libgphoto2_port.so.10: quite dirty, but just to test an older version of ligphoto2) 2) I have not tried digikam 3.0: any chance it is solved in that version ? 3) I guess bug #307839 is a duplicate of this one ? ------- Output of digikam when importing photos (which does nothing): $ digikam QSqlDatabasePrivate::removeDatabase: connection 'ConnectionTest' is still in use, all queries will cease to work. digikam(11595)/digikam (core): Failed to get information for the listed camera digikam(11595)/digikam (core): Failed to detect camera with GPhoto2 from Solid information For me this is not an issue anymore with digikam 3.0 I experienced same problem on my system (Fedora 18, 64bit) and my PTP-camera (Canon PowerShot A495). On konsole, I get the following errors: digikam(17515)/digikam (core): Failed to get information for the listed camera digikam(17515)/digikam (core): Failed to detect camera with GPhoto2 from Solid information Importing pictures with Dolphin does work as expected. Then I came across this bug-report: https://bugs.mageia.org/show_bug.cgi?id=8838 The described workaround does work for me: * manually adding USB PTP-camera in digikam * launching digikam-importer in combination with manually added camera Today there where updates on FC18 to KDE 4.10.1 & digikam 3.0.0 No changes regarding this bug - the problem still does exist here. Now there were updates on Fedora FC18 to digikam 3.1.0 This bug still exists in new digikam-version... This bug happens when the camera is being detected as a generic (PTP) device by gphoto2. In that case vendor_id and product_id are set to 0 and thus it fails when checking against the IDs given by Solid, inside GPCamera::findConnectedUsbCamera(). As long as the camera is detected to be something else than generic one (even though the name might be wrong, as it is the case with my Olympus E-PL3 which gets detected as mju 500), the IDs match and everything works just fine. The autodetect inside the options window works because it relies on gphoto2's detection instead of using the same way to check for the connected devices. Have an experimental, hacky patch for this, which relies on parsing Solid::Block's device and comparing that for the found cameras. Fixes the problem for my Coolpix S2500 The hack converts the device address given by Solid to the format gphoto2 gives out (usb:001,003 etc.), and is not really portable. Trying to look for another way to do it properly. But the question is. why in the past this feature work properly ? What has changed ? Perhaps it's in Solid API ? Gilles Caulier Maybe commit b224133f53e8428da7162c604374c7f73283d215 from the last July, adding support for gphoto2 api? Perhaps. If you revert this commit, it work better ? Gilles Caulier Created attachment 78539 [details]
fix for the regression
I did a compile-tested but otherwise untested patch for this isuse.
Many thanks Marcus for your patch. I will review it now... Gilles Caulier Created attachment 78541 [details]
0001-find-devices-by-usb-vendor-and-product-id-also-if.patch
patch against master... last was gaainst development/3.0.0
Git commit 1f0dbbd3b3a6246e8c66b038a3f1e06af2f5ee11 by Gilles Caulier. Committed on 01/04/2013 at 14:59. Pushed by cgilles into branch 'master'. Apply patch #78541 from Marcus Meissner about to find devices by usb vendor and product id, also if libgphoto2 just finds them by interface class. FIXED-IN: 3.2.0 M +58 -19 utilities/importui/backend/gpcamera.cpp http://commits.kde.org/digikam/1f0dbbd3b3a6246e8c66b038a3f1e06af2f5ee11 Tested the patch, works fine for the setup where it didn't do before (generic PTP, coolpix s2500). |