| Summary: | Searching for sleep/hibernate shows title "PowerDevil" | ||
|---|---|---|---|
| Product: | [Plasma] Powerdevil | Reporter: | Martin Flöser <mgraesslin> |
| Component: | general | Assignee: | Plasma Development Mailing List <plasma-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | afiestas, agateau, hein |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/32a6a3a8d4bc80f62e62549877efe34fa3b34366 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Martin Flöser
2012-11-09 17:01:40 UTC
This is because the search results are provided by the Powerdevil runner. I think the "Powerdevil" term should not be exposed by the runner. What do you think? agreed, it's very tech speak and also not a good name "what has the devil to do in my computer?" OK, updating product/component then. This seems to be fixed now on master at least, can you check please? (In reply to comment #4) > This seems to be fixed now on master at least, can you check please? do you have me a git commit I should be sure it's included because my current random build is still showing powerdevil. http://wstaw.org/m/2013/04/03/plasma-windowedj13293.png Using master from this morning, "sleep" produces the same results. is it possible you have a dirty installation with .desktops from before ? Can you attach a screenshot to see how the result look like? @Aurelien Gateau is there anyway of knowing which runner is outputing the element? @Alex: your screenshot is nicely highlighting the issue. Above sleep the category is called "PowerDevil" and not "Power" reopening as issue is still shown in screenshot. This happens because Plasma::AbstractRunner falls back to objectName(): http://lxr.kde.org/source/kde/kdelibs/plasma/abstractrunner.cpp#294 And the PowerDevil runner sets an objectName "PowerDevil": http://lxr.kde.org/source/kde/kde-workspace/plasma/generic/runners/powerdevil/PowerDevilRunner.cpp#43 Not sure why this fallback happens ... for some reason the KPluginInfo for the PowerDevil runner's .desktop file must be !isValid(). Ups, used CCMAIL instead of CCBUG xD... This commit fixes the technical issue: 93cc12bc720ae5a1d83495b5b320e2bc2ae7531a Now waiting for an exception to commit "Power Management" instead of "PowerDevil" This bug is reported on libsolid which is the kdelibs4 version of the solid library. It is now in maintenance mode. If you think it should still be fixed in the KDE Frameworks 5 version of solid please move it to or report a bug on frameworks-solid or Powerdevil. still visible in Plasma 5. Git commit 32a6a3a8d4bc80f62e62549877efe34fa3b34366 by Lukáš Tinkl. Committed on 13/03/2015 at 10:15. Pushed by lukas into branch 'master'. rename the visible name to Power fixes 309816 - Searching for sleep/hibernate shows title "PowerDevil" M +1 -73 runners/powerdevil/plasma-runner-powerdevil.desktop http://commits.kde.org/plasma-workspace/32a6a3a8d4bc80f62e62549877efe34fa3b34366 |
