| Summary: | Received contact request menu should have a "Block" action | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | Daniele E. Domenichelli <ddomenichelli> |
| Component: | kded-module | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | kde, mklapetek, rohan |
| Priority: | NOR | Flags: | ddomenichelli:
Decision-Required+
|
| Version: | git-latest | ||
| Target Milestone: | 0.6-next | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Somewhat relevant patch | ||
|
Description
Daniele E. Domenichelli
2012-10-22 13:21:04 UTC
Had a look at this. I tried to implement this using the blocking feature of telepathy where you can block contacts. Here's what works : No more pesky notifications Here's what does not work : Contact still shows up in the contact list, and the presence is still shown to the user who sent the request. Created attachment 74750 [details]
Somewhat relevant patch
Attaching somewhat relevant patch
(In reply to comment #1) > Here's what does not work : > Contact still shows up in the contact list, I believe it is correct, but it should be displayed only when you set the contact list to show the blocked contacts... is this true? > The presence is still shown to the user who sent the request. This is weird... what protocol are you using? I tested the "blocking" stuff some time ago and it was working correctly... Why _still_ shown? The user should not be able to see your presence (presence unknown) until you authorize him, so when you receive the request he should not see you online. If the person is authorized, when you block a contact your status goes offline (or unknown, I'm not sure). If he does, perhaps in order to test, you used an account that was your contact and you removed it and then added it again? In that case we might have some issue when removing a contact and the user is not correctly unsubscribed. Blergh, Cannot reproduce the issue. Anywho, since that issue is gone, I think I'll go ahead and submit my patch on RB. Fwiw, I just noticed this in g+'s gtalk: "N wants to be able to chat with you, and you rejected a previous request. Okay? [yes] [block]" How about showing different message for the second time? That would be stored only locally of course, but even if you loose the config file, denying one more time won't kill you.....what do you think? I think we should go back to basic of working out the use cases. It's set to be discussed in the meeting we can go through it then. Just a reminder for the meeting: we need to discuss those related bugs, consider the use cases and decide which of those are valid, and close the others. Bug 298764 - Received contact request menu should have a "Show profile" action Bug 298766 - Received contact request menu should have a "Later" action Bug 298767 - Received contact request menu should have a "Start chat" action Bug 308809 - Received contact request menu should have a "Block" action This is now done by default when we deny someone. |