Bug 308314

Summary: System Preferences button only works once
Product: [Frameworks and Libraries] print-manager Reporter: Robin Perkins <robin.perkins>
Component: generalAssignee: Daniel Nicoletti <dantti12>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:

Description Robin Perkins 2012-10-13 02:34:53 UTC
In the KDE control panel, clicking on the System Preferences button show the four checkbox options. Clicking on it again works fine.

However, after clicking on 'Overview' and going into another control panel (e.g. Sharing), then going back to 'Overview' and back into Printers clicking on the System Prefences button again gives the error prompt "Failed to get server settings. Details: Not Modified"

Closing the System Settings and opening again lets it work again.

Reproducible: Always

Steps to Reproduce:
As per details
Actual Results:  
As per details


Using the packages in Kubuntu 12.10 Beta 2
Comment 1 Daniel Nicoletti 2012-10-15 14:40:27 UTC
I know the bug and I think I've already fixed it, can you please try the git version?
Comment 2 Daniel Nicoletti 2013-01-17 02:47:43 UTC
Git commit 03250ca3e9e1f069f13c22099bb63bd4d9fc1078 by Daniel Nicoletti.
Committed on 17/01/2013 at 03:46.
Pushed by dantti into branch 'KDE/4.10'.

Rely on cupsAdminGetServerSettings() return value to know if the request went fine since it might just read the local file

M  +1    -8    libkcups/KCupsConnection.cpp
M  +0    -9    libkcups/KCupsConnection.h
M  +27   -17   libkcups/KCupsRequest.cpp
M  +3    -1    libkcups/KCupsRequest.h
M  +0    -11   printer-manager-kcm/PrintKCM.cpp
M  +0    -1    printer-manager-kcm/PrintKCM.h

http://commits.kde.org/print-manager/03250ca3e9e1f069f13c22099bb63bd4d9fc1078