Summary: | When more than one tab and the integrated Konsole are open paths gets mixed | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Haris Tampakopoulos <ctampak> |
Component: | panels: terminal | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | reproducible |
Priority: | NOR | ||
Version: | 2.1 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-baseapps/9111135f2c5343e4e09828e805ea8d152e527914 | Version Fixed In: | 4.9.2 |
Description
Haris Tampakopoulos
2012-09-06 15:00:14 UTC
The root cause is the same as for bug 304838. I'll try to have a look and see if we can prevent this unwanted behaviour. Git commit 9111135f2c5343e4e09828e805ea8d152e527914 by Frank Reininghaus. Committed on 19/09/2012 at 09:28. Pushed by freininghaus into branch 'KDE/4.9'. Prevent unwanted URL changes when using the Terminal Panel The root cause of the problem was that TerminalPanel's member m_konsolePartCurrentDirectory, which is used to determine in TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's directory is aleady 'dir', such that issuing the 'cd' command is not needed, was updated too late, namely when the part's currentDirectoryChanged(QString) signal was received, which may be up to one second after the 'cd' command. When changing the directory from "dir1" to "dir2" and going back to the "dir1" in less than one second (either by using the 'Back' action or by activating a tab which still had "dir1" open), the 'cd dir1' command was therefore suppressed because the Terminal Panel still thought that "dir1" was the current directory in the part. However, the directory of the part was actually "dir2", and when the currentDirectoryChanged(QString) signal was received from the part, the view's URL was set to "dir2" as well. Related: bug 304838 FIXED-IN: 4.9.2 M +1 -0 dolphin/src/panels/terminal/terminalpanel.cpp http://commits.kde.org/kde-baseapps/9111135f2c5343e4e09828e805ea8d152e527914 |